Skip to content

SOLR-18465: Remove stray shell-prompt character from a bin/solr example - #4923

Closed
serhiy-bzhezytskyy wants to merge 1 commit into
apache:mainfrom
serhiy-bzhezytskyy:SOLR-18465-spatial-curl-format
Closed

serhiy-bzhezytskyy wants to merge 1 commit into
apache:mainfrom
serhiy-bzhezytskyy:SOLR-18465-spatial-curl-format

Conversation

@serhiy-bzhezytskyy

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-18465

Description

The Spatial page's only console example (bin/solr post ... for indexing GeoJSON/WKT) had a leading $, unlike the other 32 bin/solr examples in the ref guide, which would make a copy-pasted command fail.

Solution

Removed the $.

Note

This ticket's description field is empty, and the page doesn't actually contain any curl commands (only this one bin/solr post example and some bare HTTP query-string fragments). This PR fixes the one concrete formatting defect I could find; if more was intended, happy to take a pointer to it.

Tests

N/A — single-character doc fix, verified by inspection against the other 32 bin/solr examples in the ref guide.

AI-assisted (Claude Sonnet 5).

The Spatial page's only console example had a leading $, inconsistent with the other 32 bin/solr examples in the ref guide, which would make a copy-pasted command fail.
@serhiy-bzhezytskyy

Copy link
Copy Markdown
Contributor Author

@epugh tagging you since this is under SOLR-18459/SOLR-18465, which you filed — see the note above about the ticket's scope.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 20, 2026

[,console]
$ bin/solr post -t "application/json" --solr-url http://localhost:8983 --name mycollection --params "format=geojson" /path/to/geojson.file
bin/solr post -t "application/json" --solr-url http://localhost:8983 --name mycollection --params "format=geojson" /path/to/geojson.file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've been doing --content-type?

@epugh

epugh commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

can we fold this into #4925 since that fixes these everywhere? Also, this one uses -t but we use -H elsewhere in #4925. I don't think this one change is worth a full PR.... I will look at the spaital page again and see if there are other issues or not.

@serhiy-bzhezytskyy

Copy link
Copy Markdown
Contributor Author

Correction to the description of this PR: the leading $ is not the problem. 101 of the 154 bin/solr examples in the guide start with $ and the copy button drops it for console blocks, so I'm withdrawing that change. What is wrong here is that [,console] is followed directly by the command with no ---- delimiters, so the built page shows a plain paragraph with an auto-linked URL instead of a code block. It is the only one of the 141 [,console] blocks in the guide without them. -t is the short name of bin/solr post --type (there is no --content-type), and it is what both examples that set a content type use, so it differs from curl's -H only because it is another tool. As you suggested, I'm closing this one; the delimiter fix is in #4925 now (ecb4dce), which did not touch this page before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants