Repository navigation
Conversation
Member
|
Thanks for this. The three changes are unrelated, touch different modules and will need separate review rounds and separate release notes, so please split this PR into three, each with its own Jira ticket:
Review comments will follow on each PR separately. Thanks! |
AbstractMatcher/ActionConfigMatcher: a wildcard "{n}" substituted into an
action/result/exception-mapping class= attribute was unconfined, unlike the
sibling method-name slot (ActionConfig#isAllowedMethod). A substituted segment
containing '.' or '/' is now rejected rather than used verbatim.
Reachable only if a developer writes a wildcard mapping with a substituted
class name -- application-responsibility, not a default-config issue.
Tests: WildcardClassNameHardeningTest (new, 2 tests). Full core suite:
3742/0 failures.
g0w6y
force-pushed
the
WW-5839-input-hygiene-hardening
branch
from
November 7, 2026 09:26
ec24682 to
6619965
Compare
g0w6y
changed the title
Contributor
Author
|
Done -- this PR is now narrowed to just the wildcard class-name item (6619965), title/description updated to match. #2116 is open against WW-5840 for the upload file name item. Still working on a new ticket for the Boot session tracking item before opening its PR. Will update WW-5839's Jira description to match too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WW-5839
AbstractMatcher/ActionConfigMatcher: a wildcard{n}substituted into an action/result/exception-mappingclass=attribute was unconfined, unlike the sibling method-name slot (ActionConfig#isAllowedMethod). A substituted segment containing.or/is now rejected rather than used verbatim.Reachable only if a developer writes a wildcard mapping with a substituted class name -- application-responsibility, not a default-config issue.
Verified:
WildcardClassNameHardeningTest(new, 2 tests). Fullcore: 3742/0 failures.