Repository navigation
Disallow document() and evaluate() in re-compiled template parameters - #124
Open
ThisaraWeerakoon wants to merge 1 commit into
Open
ThisaraWeerakoon wants to merge 1 commit into
ThisaraWeerakoon wants to merge 1 commit into
Conversation
A dynamic template parameter in the escaped {{...}} form is evaluated once
and its result is re-compiled into a new XPath expression. Since that
expression is derived from a runtime value, it is now rejected if it calls
document() or evaluate(). All other functions and the single-evaluation
parameter forms are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dynamic template parameter in the escaped
{{...}}form is evaluated once and its result isre-compiled into a new XPath expression, which runs again via
$func:<param>. Since thatexpression is built from a runtime value, it should only resolve through self-contained XPath
functions.