Skip to content

Fix C++ sketch CLI build on develop - #979

Closed
ColinLeeo wants to merge 1 commit into
apache:developfrom
ColinLeeo:colin/fix-develop-build
Closed

ColinLeeo wants to merge 1 commit into
apache:developfrom
ColinLeeo:colin/fix-develop-build

Conversation

@ColinLeeo

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix the C++ build on develop by using the existing LocalRandomAccessReadFile implementation in the sketch CLI instead of the nonexistent file/read_file.h and storage::ReadFile types.

Why is this change needed?

origin/develop failed to compile cpp/tools/commands/sketch_layout.h with:

fatal error: 'file/read_file.h' file not found

The sketch implementation already calls the local random-access file API, so the header and member type should use that concrete implementation.

How was this tested?

  • Built the complete C++ target with CMake, including TsFile_Test.
  • Ran the four sketch-related tests covering CLI requirements and tree/table models.
  • Ran clang-format validation and git diff --check.

@ColinLeeo ColinLeeo closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant