Repository navigation
Conversation
The archetype integration test ran clean verify on the generated project with whatever Wicket artifacts the local repository or the Apache snapshot repository held. CI runs verify without install, and the archetype module did not depend on the modules the generated project uses, so the reactor could even build it before them. A change to wicket-core or wicket-native-websocket-javax was tested against the previous nightly snapshot, and right after a version bump the generated project could not resolve Wicket at all until a snapshot of the new version was published. The archetype module now declares the generated project's Wicket modules as test dependencies, which orders it after them in the reactor, and maven-invoker-plugin:install copies them, their reactor dependencies and their parent poms into the local repository before the integration test runs. A plain mvn verify therefore writes these snapshots to the local repository, as mvn install would have. The installation and the integration test both follow -DskipTests, so a build that skips tests no longer generates and builds a project; -Darchetype.test.skip still skips the integration test alone. Start.java loses what was left over from Jetty 11: the unused session store imports, the commented-out session cache line and the obsolete JSR-356 instructions. The JSESSIONID hint uses the Jetty 12 session handler API, and the HTTP idle timeout is the literal it was before. GitHub issue #1658 Generated-by: Claude Code (Claude Opus 5.5)
The previous commit turned the idle timeout back into 1000 * 60 * 60, undoing the Duration the original port introduced. Duration.ofHours(1) states the intent more plainly; toMillis() is passed as is, because setIdleTimeout takes a long and needs no cast to int. The timeout stays one hour, and the HTTPS connector keeps its own value. GitHub issue #1658 Generated-by: Claude Code (Claude Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.