Repository navigation
fix(metadata): allow GraphQL operations in parameter attributes on properties - #8621
Open
Maxcastel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8552 throws when a parameter attribute on a property is restricted to an operation the resource does not declare, but it only looks at
operations: restricting it to a GraphQL operation declared ingraphQlOperationsalways throws:Before
#[ApiResource( operations: [ new GetCollection(), ], graphQlOperations: [ new QueryCollection(), ] )] class Book { #[QueryParameter(key: 'search', operations: [new QueryCollection()])] public string $name = ''; }RuntimeException: Parameter attribute on property "name" is restricted to the operation "ApiPlatform\Metadata\GraphQl\QueryCollection" which is not declared on the resource "App\Entity\Book".After
The
searchparameter is added to theQueryCollectionGraphQL operation only (not to the HTTPGetCollection). An operation declared in neitheroperationsnorgraphQlOperationsstill throws.