Repository navigation
Conversation
|
hi @AlexXuz would you be interested in trying a more maintained fork of this package and contributing the fix there as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a directory containing two files, a data function returning fresh metadata hangs after the first entry:
The traversal-resume callback is attached before the transform, so a replacement object drops it.
Change
Attach the internal callback after the transform and false-skip handling, immediately before appending the entry. Add four regression cases: replacement objects, in-place mutation, copied objects, and skipping a match before returning fresh metadata. Tests verify finalized JSON archive names, types, and sizes, with bounded timeouts and cleanup.
Validation
npm test: 44 passing on Node.js 24.22.1 / Linux.git diff --checkpass.Not tested locally on Windows or other Node.js versions.