Repository navigation
fix(game): pin the score card in landscape, add Close to the phone sign-in sheet - #309
Merged
Merged
Conversation
arrzdev
marked this pull request as ready for review
November 9, 2026 21:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Sheetso other sheets are unchanged. Close and Escape both leave the visitor on home with focus on the home heading instead of<body>.Modalno longer treats<body>as an opener to hand focus back to.Visual changes, so this stays a draft until the before/after screenshots are approved.
How to verify
pnpm test:e2e e2e/landscape-score.spec.ts e2e/signin-sheet-close.spec.ts --project=chromium --project=webkit-iphone. Both specs fail onmain. Typecheck, Biome and the game build pass.UI quality gate