Repository navigation
test(game): measure the phone sign-in sheet once it stops sliding - #310
Merged
Merged
Conversation
The Close check ran expectNoClippedText while the sheet was still sliding up, so its lower half sat under the screen's edge and read as cut-off text. Wait for the sheet to rest first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone sign-in sheet spec checked for clipped text right after the Close button became visible. The sheet was often still sliding up at that point, so the Password label and Sign in button sat below the 667px viewport (reported at y 678 to 813) and counted as cut off. The spec failed about 2 runs in 3 in isolation.
It now waits for the sheet to come to rest (
waitForRest, the same helper the layout-shift and rhythm checks use) before it measures text and the Close box. No product change.Verify:
pnpm test:e2e e2e/signin-sheet-close.spec.ts --project=chromium --repeat-each=10gives 30 passed locally.