Repository navigation
Ship the licenses of the bundled third-party code - #18
Merged
Merged
Conversation
CDT bundles predicates.h, which is BSD-3-Clause, and code from LLVM's libc++, which is Apache-2.0 with LLVM exceptions. Both are compiled into the module, but the wheels declared only MPL-2.0 and shipped only its license. Update CDT to the commit that adds the two license files, and list them in license-files, so that the sdist and the wheels carry all of them. The license expression now covers the bundled code, and the README lists it.
artem-ogre
force-pushed
the
third-party-licenses
branch
from
October 12, 2026 20:22
05ed1a4 to
b04fc5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDT compiles
predicates.h(BSD-3-Clause) and code from LLVM's libc++ (Apache-2.0 WITH LLVM-exception) intopythoncdt._core, but the wheels declare onlyMPL-2.0and ship only its license. The conda-forge recipe (conda-forge/staged-recipes#35148) works around it with its own copies of the missing licenses.Update CDT to artem-ogre/CDT#231, which adds the two license files, and list them in
license-files. The license expression now covers the bundled code:MPL-2.0 AND BSD-3-Clause AND Apache-2.0 WITH LLVM-exception. The README lists the third-party code.CDT's new install rule adds nothing to the wheel, which only installs the
pythoncomponent.