Repository navigation
feat(grpc-playground)!: migrate to Next 16 and React 19 - #32
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46fdcd390f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
Как проверять
Основной сценарий
@atls/grpc-playground-appустановлен в чистой директории вне monorepo. Действие: запуститьnpm run start, открыть Playground, выбрать Echo, переключиться на Form, изменитьpingи нажать ▶. Ожидаемый результат: страница загружается, а ответ содержит введённое значение.int32на42,int64на9007199254740993,uint64на18446744073709551615и нажать ▶. Ожидаемый результат:int32остаётся числом, оба 64-битных поля приходят точными десятичными строками без округления.Дополнительный сценарий
/api/grpc-proxyмаршрута, загрузить JS/CSS и файл ScienceGothic из/_next/static. Ожидаемый результат: оба API отвечают200с JSON, ресурсы отвечают200, CSS ссылается на упакованный шрифт; браузерный клиент обращается к/api/grpc-proxy.yarn install --immutable,yarn check --verify,yarn workspace @atls/grpc-playground-app packиyarn version apply --all --dry-run. Ожидаемый результат: проверки и сборка архива проходят; планируется только major@atls/grpc-playground-app@1.0.0, приватные workspaces получаютdecline.Пруфы
next start distотдал страницу, оба API route и JS-ресурс. В браузере Echo вернул изменённый текст, Number сохранил 64-битные значения"int64": "9007199254740993"и"uint64": "18446744073709551615", аint32остался числом.200; ответы API содержат ожидаемый JSON.@atls-ui-parts/text@1.1.2проверен в npm по SHA512 иgitHead; временныйpackageExtensionsудалён. Приложение использует Next 16.4.0, React 19.3.0 и поддерживаемые Hyperion UI Parts.URLPatternв Next 16.4 локальная Yarn resolution применяет узкий патч по upstream PR для TypeScript 5.9 из Raijin. В опубликованном manifest остаётся обычная зависимостьnext: 16.4.0;skipLibCheckне включён.{"ping":"final"}{"ping":"final"}