Repository navigation
B-03: accessibility events without the UI lock; notificationTimeout 0 - #71
Merged
austinintelligence merged 7 commits intoOct 15, 2026
Merged
Conversation
Events bump an atomic generation and the last-event time instead of taking the UI lock; a scene older than the generation is rebuilt on demand. The quiet window is configurable (AU_QUIET_MS, default 200) and benchmark-live can sweep it with BENCH_QUIET_MS. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBuuDWN89yt1W59QT8aHLo
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cache a half-old scene Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBuuDWN89yt1W59QT8aHLo
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBuuDWN89yt1W59QT8aHLo
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBuuDWN89yt1W59QT8aHLo
austinintelligence
changed the base branch from
claude/b-02-generation-polling
to
claude/friendly-dirac-embe85
October 15, 2026 17:48
Vm.java: keeps A-18's p.unguarded() check; the comment now gives both B-03's reason (blocking other workers' reads) and A-18's (a capture blocking taps). Gates and helper javac pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLaa2TojSgBwyk35cJjco
austinintelligence
merged commit Oct 15, 2026
dc0202f
into
claude/friendly-dirac-embe85
6 checks passed
austinintelligence
added a commit
that referenced
this pull request
Oct 15, 2026
A-01 budgets and fail-closed gates, with these merged into it in dependency order: B-10 #65, B-01 #62, A-20 #76, A-21 #61, A-09 #56, A-07 #68, A-04 #63, A-10 #59, A-11 #72, A-12 #57, A-13 #73, A-17 #58, A-18 #67, A-19 #70, B-11 #69, A-15 #64, B-02 #60, B-03 #71, B-05 #74, B-04 #75, B-06 #77, B-07 #78, B-13 #82, A-14 #86, A-16 #84, B-08 #87, B-09 #88, A-02 #79, A-03 #80, A-05 #83, A-06 #81, A-08 #85, B-12 #66. All checks green on Linux, macOS and Windows (Rust, helper build and format, installer, package smoke, CodeQL, dependency audit). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLaa2TojSgBwyk35cJjco
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Ui.onAccessibilityEventno longer takes the UI lock. The generation is anAtomicLongthat every event bumps, and the last-event time is volatile. The cached scene is stamped with its generation andsnapshot()rebuilds it when it is older. (An earlier version skipped bumps within 40 ms of the last one; that could drop an event during a rebuild and cache a half-old scene, so every event now bumps.)notificationTimeout50 → 0 inaccessibility_service_config.xml.AU_QUIET_MS(1 to 900, else the default). The helper still receives it in the plan'ssettleop.cargo xtask benchmark-livewithBENCH_QUIET_MS=200,150,120runs the benchmark once per value, writesbenchmark-live.<ms>ms.jsonfor each, and printsquiet_ms=… tap_p50=… tap_p95=… success=…. How to run it is indocs/contributing/testing.md.Why
Event-thread half of finding #5: events contending with readers for the UI lock delayed
settle's view of the screen. The sweep is how we choose the quiet window against the 1.3.0 tap gate (p50/p95 600/1,500 ms).Test:
the_quiet_window_defaults_to_200_and_takes_a_sane_overrideincomputer/src/agent_tests.rs(fails before, becausequiet_windowdoes not exist). The helper change has no JVM test:Uiis anAccessibilityServiceand cannot run on the JVM here.Safety and compatibility
adb, or page JavaScript; command forms are unchanged.AU_QUIET_MSis a host-side setting, not an agent command.Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-targetscargo xtask checkandcargo xtask docsnpm testandnpm run lint(not run)Not done here
helperCI job is the first compile.notificationTimeout 0withtypeAllMaskandflagIncludeNotImportantViewsdelivers every content-change event unbatched: event rate and CPU on a busy screen (scrolling list, video) are not measured.Release impact
Stacked on #60 (B-02); retarget to
claude/friendly-dirac-embe85ormainas the earlier PRs merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01VBuuDWN89yt1W59QT8aHLo