Repository navigation
test(parser): cover optional SES common headers including replyTo - #8525
leandrodamascena merged 1 commit into
Conversation
3b9a56c to
6c06a42
Compare
|
leandrodamascena
left a comment
There was a problem hiding this comment.
Hi @LuisFigueroaG, I owe you an apology. You reported #8523 and sent this fix three days before #8542, and we ended up reviewing and merging the later one without noticing yours. That was our mistake.
Rather than closing this, I rebased your branch on develop and kept your test, which is more complete than the one we merged since it goes through SesModel with the full event and also covers cc, bcc and sender. The alias change is already in develop, so this PR now carries only the test, still authored by you. Approving so you land as a contributor in this release. Thank you, and sorry again for the mix-up!
|
Referenced issues are closed or don't exist. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
07a2cf3
into
aws-powertools:develop
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8525 +/- ##
========================================
Coverage 96.92% 96.92%
========================================
Files 317 317
Lines 15976 15976
Branches 1413 1413
========================================
Hits 15484 15484
Misses 349 349
Partials 143 143 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|



Issue number: closes #8523
Summary
Changes
Adds a test that parses a full SES event with
SesModeland checks that the optionalcommonHeadersfieldscc,bcc,senderandreply_toare populated.The
replyToalias fix originally in this PR was merged separately in #8542, so this PR now carries only the test, which goes through the full event and covers more fields than the one merged there.User experience
No runtime change. Better regression coverage for
SesMailCommonHeaders.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.