Skip to content

test(parser): cover optional SES common headers including replyTo - #8525

Merged
leandrodamascena merged 1 commit into
aws-powertools:developfrom
LuisFigueroaG:fix/ses-parser-reply-to
Oct 16, 2026
Merged

leandrodamascena merged 1 commit into
aws-powertools:developfrom
LuisFigueroaG:fix/ses-parser-reply-to

Conversation

@LuisFigueroaG

@LuisFigueroaG LuisFigueroaG commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Issue number: closes #8523

Summary

Changes

Adds a test that parses a full SES event with SesModel and checks that the optional commonHeaders fields cc, bcc, sender and reply_to are populated.

The replyTo alias fix originally in this PR was merged separately in #8542, so this PR now carries only the test, which goes through the full event and covers more fields than the one merged there.

User experience

No runtime change. Better regression coverage for SesMailCommonHeaders.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@LuisFigueroaG
LuisFigueroaG requested a review from a team as a code owner October 6, 2026 02:29
@LuisFigueroaG
LuisFigueroaG requested a review from svozza October 6, 2026 02:29
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2026
@boring-cyborg boring-cyborg Bot added the tests label Oct 6, 2026
@leandrodamascena leandrodamascena changed the title fix(parser): read replyTo from SES common headers test(parser): cover optional SES common headers including replyTo Oct 16, 2026
@sonarqubecloud

Copy link
Copy Markdown

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuisFigueroaG, I owe you an apology. You reported #8523 and sent this fix three days before #8542, and we ended up reviewing and merging the later one without noticing yours. That was our mistake.

Rather than closing this, I rebased your branch on develop and kept your test, which is more complete than the one we merged since it goes through SesModel with the full event and also covers cc, bcc and sender. The alias change is already in develop, so this PR now carries only the test, still authored by you. Approving so you land as a contributor in this release. Thank you, and sorry again for the mix-up!

@powertools-for-aws-oss-automation

Copy link
Copy Markdown

Referenced issues are closed or don't exist. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@leandrodamascena
leandrodamascena merged commit 07a2cf3 into aws-powertools:develop Oct 16, 2026
11 of 12 checks passed
@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (4624628) to head (6c06a42).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8525   +/-   ##
========================================
  Coverage    96.92%   96.92%           
========================================
  Files          317      317           
  Lines        15976    15976           
  Branches      1413     1413           
========================================
  Hits         15484    15484           
  Misses         349      349           
  Partials       143      143           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: SesModel ignores the replyTo common header

2 participants