Repository navigation
fix(event_handler): match AppSync Events wildcard routes on segment boundaries - #8546
Open
LemonCondor wants to merge 1 commit into
Open
LemonCondor wants to merge 1 commit into
LemonCondor wants to merge 1 commit into
Conversation
…oundaries find_best_route() turned a trailing "/*" into ".*" by slicing six characters off "[^/]+", which also removed the preceding "/". A route such as "/default/users/*" was compiled to ^/default/users.*$ and matched "/default/usersettings", so that channel was dispatched to the more specific but wrong handler instead of "/default/*". Strip only the wildcard pattern so the separator is kept.
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
powertools-for-aws-oss-automation
Bot
added
the
size/M
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8545
Summary
Changes
find_best_routeturned a trailing[^/]+into.*withpattern[:-6]."[^/]+"is 5 characters, so the/before it was dropped too:/default/users/*became^/default/users.*$. This PR strips only the wildcard, so the regex is^/default/users/.*$, as the docstring already describes. It also fixes the docstring example for/default/v1/*.Tests:
test_appsync_events_resolvers.py, which publishes to/default/usersettingswith handlers on/default/*and/default/users/*;find_best_routeintest_functions.py.Without the fix both fail. With the fix, the appsync events unit and functional tests pass.
User experience
Before: publishing to
/default/usersettings(or/default/users-archive/1) ran the/default/users/*handler.After: it runs the
/default/*handler. Channels under/default/users/...still go to/default/users/*.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.