Repository navigation
Conversation
Anonymous pulls of the durable execution emulator image from Public ECR fail with "toomanyrequests: Data limit exceeded", which fails every test in the lane. Log in with the OIDC role for same-repo PRs and the merge queue. Fork PRs get no OIDC token, so they keep pulling anonymously. The credentials go to step outputs only, so the test step does not see them.
Contributor
Author
|
Superseded by #9364, opened from a branch in this repo so the new Public ECR login steps run in its own CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
No issue. CI failure seen on #9357: run 39695728257.
Why is this change necessary?
The
durable-functionslane inbuild.ymlpulls the emulator image from Public ECR without logging in. Public ECR rate-limited the runner, and all 32 tests in the lane failed:integration-tests.ymlalready logs in (tests/setup_testing_resources.py).build.ymldoes not.How does it address the issue?
For the
durable-functionslane only:id-token: writeso it can use OIDC.OIDC_ROLE_ARNwith the same pinnedconfigure-aws-credentialsaction thatintegration-tests.ymluses, then runsdocker login public.ecr.aws.output-env-credentials: false), so the pytest step never sees them.What side effects does this change have?
merge_groupruns.pushandscheduleruns today. If its trust policy does not allowpull_requestandmerge_groupsubjects, the steps fail without failing the job (continue-on-error), and the lane pulls anonymously as it does now.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpasses (N/A, no Python changes)make update-reproducible-reqsif dependencies were changed (N/A)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.