Skip to content

test/read-before-exit: wait for deferred ring frees on -ENOMEM #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7z0423arsenova wants to merge 1 commit into from
Closed

test/read-before-exit: wait for deferred ring frees on -ENOMEM #1663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions test/read-before-exit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,44 @@ static void *submit(void *data)
return NULL;
}

/*
* Without CAP_IPC_LOCK, ring memory counts against RLIMIT_MEMLOCK. Every
* ring here exits with requests still pending, which makes the kernel free
* it asynchronously, and the loops below create rings faster than those
* frees complete. Give them time to catch up rather than failing on
* -ENOMEM.
*/
static enum t_setup_ret create_ring(struct io_uring *ring, int flags)
{
struct io_uring_params params;
int i, ret;

for (i = 0; i < 100; i++) {
memset(&params, 0, sizeof(params));
params.flags = flags;
ret = io_uring_queue_init_params(8, ring, &params);
if (ret != -ENOMEM || !geteuid())
break;
usleep(10000);
}
if (!ret)
return T_SETUP_OK;

/* let the helper handle skips and report the error */
memset(&params, 0, sizeof(params));
params.flags = flags;
return t_create_ring_params(8, ring, &params);
}

static int test(int flags)
{
struct io_uring_params params = { .flags = flags, };
struct io_uring ring;
struct data d = { .ring = &ring, };
pthread_t thread;
void *res;
int ret;

ret = t_create_ring_params(8, &ring, &params);
ret = create_ring(&ring, flags);
if (ret == T_SETUP_SKIP)
return 0;
else if (ret != T_SETUP_OK)
Expand Down Expand Up @@ -110,7 +138,7 @@ int main(int argc, char *argv[])
for (i = 0; i < 1000; i++) {
ret = test(IORING_SETUP_IOPOLL);
if (ret) {
fprintf(stderr, "Test IOPOLL failed loop %d\n", ret);
fprintf(stderr, "Test IOPOLL failed loop %d\n", i);
return ret;
}
if (no_iopoll)
Expand Down