Repository navigation
[BUGFIX] Render pages for content extraction uncached - #44
Merged
Merged
Conversation
FrontendPageRenderer sent its in-process request through the regular
page cache. Called from a backend request, the output has file URLs
prefixed twice ("//fileadmin/...") because the backend and the
frontend PublicUrlPrefixer are both registered; from CLI they come
out relative. That page was then served to every visitor.
Disable the page cache for the render request (CacheInstruction on
TYPO3 13/14, the noCache attribute on 12.4).
Resolves: #43
The render bypasses the page cache for reading as well, so a page cached by a visitor's request is rendered again. A test now covers that next to the existing write test. Shorten the docblock of withPageCacheDisabled() to its contract, reference the issue in the changelog entry and shorten the description of the test fixture extension. Related: #43 Signed-off-by: Oliver Bartsch <bo@cedev.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrontendPageRenderer renders a page in-process and sent that request through the regular page cache. The output is not what a visitor would get: called from a backend request, TYPO3 has already registered the backend PublicUrlPrefixer, the frontend RequestHandler adds its own, and both prefix file URLs, so they come out as "//fileadmin/...". From CLI the site path is empty and they come out relative. The request carries no cookies, so the page was stored in the page cache and served to every visitor, with every image broken.
The render request now has the page cache disabled: CacheInstruction::disableCache() on TYPO3 13/14, the "noCache" attribute on 12.4. Pages already cached with such URLs stay broken until the page cache is flushed.
The new functional test renders a page through the renderer and asserts that the page cache holds no entry for it. It fails without the change. It needs the pages cache off the NullBackend, and a fixture middleware that adds the testing framework's internal request context, because the json_response middlewares fail on requests that executeFrontendSubRequest() did not build.
Resolves: #43