Repository navigation
Conversation
|
Hi @infabo |
|
Hi @achimfritz
I am not going to "advertise" that feature to core maintainers. Submitting a core patch is kind of effort, you have to persuade core members of the "why this is needed". A very difficult part. In first place, the main reason, this PR should fix the close/save not returning to the correct position in page layout view again. This is an established and known core behaviour - and should also be functioning inside a container. Would you merge this PR when I remove the "delete" handling? Nobody would miss it anyways and it simplifies the PR. Thanks |
|
Hi @infabo , I'm not seeing it, i have testet v14:
|
|
any news? |
|
I am sorry, I did not understand your questions. Or how your questions are related to my previous comment. |
|
Sorry if my questions were unclear, let me try again. I (honestly claude in this case) compared the behavior with TYPO3 core v14 (EXT:backend, GridColumnItem / GridColumn):
So right now, EXT:container behaves exactly like core. In particular, I can't reproduce "saving returns to the top" on v14: editing a child inside a container and using save & close brings me back to that element. That's why I'm asking for concrete steps, e.g.:
If save & close inside a container really doesn't return to the element in some setup, that's a bug and we'll fix it. The other two parts (anchors after creating and deleting) are new behavior that core doesn't have for regular columns either. Also, the anchor after creating points to the element before the new one, not to the new element. We'd rather not change this only for container columns. That would be a good improvement for core, so the behavior is consistent across all columns. |
That's why I have created this patch and submitted the PR. I admit, it went over the top because I wanted to "gold plate" (delete, create handling). I'll try to setup a clean install and try to reproduce the original issue I have observed and return with a modified PR. The most important infos I can provide directly from my memory:
|
…-layout-position # Conflicts: # Tests/Functional/Backend/Service/NewContentUriBuilderTest.php
|
Update from Codex (OpenAI, GPT-5) — AI-assisted implementation and verification on behalf of @infabo. Thanks for the detailed comparison. Your table is correct, and the previous description conflated editing an existing child with creating a new child. The PR does not modify existing-record edit links, so there is no save-and-close bug for existing records addressed here. I have now:
The concrete scenario behind the remaining change is:
Because the new record UID does not exist when the URL is built, the patch anchors to the insertion target (the preceding element), or to the parent container when inserting at the top. That explains why it cannot point to the newly created element itself. I agree this is also relevant to regular core columns. The remaining rationale for this PR is that Local verification on the updated branch: the focused functional suite passes with 6 tests / 42 assertions on PHP 8.5 and TYPO3 13.4.36; PHP-CS-Fixer dry run passes. The new GitHub Actions run is currently |
Problem
Creating a child content element inside a long or nested container returns editors to the top of the Page module after the new-content wizard or record editor closes. This is disruptive when the insertion point is outside the viewport.
This pull request is limited to container-specific new content element URLs. Editing existing records and deleting records are not changed.
Solution
creationOptions.saveAndClosedirect-creation path introduced on currentmaster.The new record UID is not known when these URLs are built, so the closest stable target is the existing element before the insertion point, or the parent container for insertion at the top.
Verification
master: 6 tests, 42 assertions.AI disclosure
This pull request, including its implementation, tests, and description, was updated with OpenAI Codex using the GPT-5 model. The resulting changes were reviewed and verified with the checks listed above.