Skip to content

test(legacy): add zero address validation for setOwner - #448

Open
forumevi wants to merge 1 commit into
base:mainfrom
forumevi:test/add-zero-address-owner-validation
Open

forumevi wants to merge 1 commit into
base:mainfrom
forumevi:test/add-zero-address-owner-validation

Conversation

@forumevi

@forumevi forumevi commented Oct 6, 2026

Copy link
Copy Markdown

This test ensures that ownership cannot be accidentally transferred to address(0), which would permanently lock the proxy contract.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@forumevi

forumevi commented Oct 6, 2026

Copy link
Copy Markdown
Author

@maintainers Hi! 👋

I've added a security test to ensure setOwner cannot be called with address(0), which would permanently lock the proxy contract.

The workflow is awaiting approval. Could someone please approve and run the CI checks?

Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants