Repository navigation
feat(vibenet): track ERC-8168 update — payer authorizes before the user signs - #182
Open
chunter-cb wants to merge 1 commit into
Open
chunter-cb wants to merge 1 commit into
chunter-cb wants to merge 1 commit into
Conversation
…r signs) - payer_signTransaction is called on the unsigned tx and returns payerAuth; the sender signs once with it in place, then the page broadcasts - co-sign param renamed to `transaction`; getTerms gasLimit excludes phase 0 - COST_EXCEEDS_LIMIT message; tolerate an absent paymentAmount - rebuild vendor/aa from viem feat/aa-tx-split (37aa9cf1f); refresh ERC-8168 types
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the account demo to the latest ERC-8168 draft (ethereum/ERCs#1555).
Merge after https://github.com/base/vibenet/pull/73 is deployed. This ui sends the renamed
transactionparam, which the payer running today doesn't accept.payer_signTransaction,signComposedserializes the transaction withoutsender_auth. It getspayerAuthfrom the payer through the newComposePayer.authorizehook, then the user signs once with it in place and the page broadcasts. A payer rejection no longer comes after the user has signed.payer_sendTransactionuses{ transaction }.getTermsgasLimitnow covers only the user calls (the spec excludes phase 0; the payer addspaymentGas).COST_EXCEEDS_LIMITmessage, handles a missingpaymentAmount(the amount is still priced fromrate), and refuses native-token offers, which this dialog doesn't build.vendor/aafrom viemfeat/aa-tx-split(37aa9cf1f), exportsserializeTransaction,encodePaymentandrequiredPaymentAmount, and refreshes the hand-written ERC-8168 types (which still had the old{numerator, denominator}rate).Testing
tscpasses (only stale.nextroute types fail), andeslintpasses on the changed files.vitest: 417 tests pass.tmp/smoke-eoa-payer.mjsin vibenet), landed USDV-paid and free-grant transactions on live vibenet against the payer from vibenet#73.