Skip to content

v0.2.0: broad coverage, triggers, batch actions, API request - #1

Merged
BatchDataAPI merged 3 commits into
mainfrom
dev
Oct 29, 2026
Merged

BatchDataAPI merged 3 commits into
mainfrom
dev

Conversation

@BatchDataAPI

Copy link
Copy Markdown
Contributor

Summary

Adds: BatchData node covering V1-V3 operations (reverse skip trace, permits, batch skip trace, batch lookup, batch address verify, autocomplete, geocode, reverse geocode, investor buy box and properties, search sessions, property monitors, generic API request); BatchData Trigger (polling: new search session, new monitor, new session property); BatchData Monitor Trigger (webhook: create/check/delete subscription, eventId dedupe, optional billed hydration).
Testing: 37 node:test tests pass; n8n-node lint, build and tsc clean.

Risk: Medium. New customer-facing integrations; no production services touched. Billing is per record, so a bug that sends extra requests costs customers money. Property monitors are limited (5 per team, immutable), so a bug in subscribe/unsubscribe could use up a team's slots.
How to revert: Do not publish. If already published, unpublish or deprecate the package/app version and revert this PR.
Required reviewers: One engineer for code. Ivo for naming and the phone-compliance and billing wording.
Review: Post-coding review by Claude, see review/claude-review-v02.md (or the note in the final report if it could not run); plus a self-review.
Webhook decision: Instant triggers create a V2 property subscription with deliveryConfig {type: "webhook", url: <the trigger's own hook URL>} on subscribe and delete it on unsubscribe. Users never enter a callback URL; webhookUrl and errorWebhookUrl are stripped or blocked everywhere else.
Billed hydration (opt-in): The instant trigger delivers IDs only. Adding the full property record runs a billed property lookup per event, so it is off by default (a toggle in n8n and Zapier, a separate module in Make).
Verified vs mocked: Everything except monitors and the instant triggers was checked live with 1 record per call. Monitors and instant triggers are mocked only (the available token gets 403 on subscription endpoints); verify with a sandbox token before publishing.

Review result: Claude post-coding review ran on the v0.2.0 code. Findings fixed in this PR: callback keys now stripped from free-form query JSON (n8n, Zapier); Make API call blocks (and sends no body or query for) bodies that contain webhook or a JSON unicode escape, and the Make instant trigger dedupes on eventId; stale Zapier README bullets removed. Known gap, documented: Make cannot strip callback keys recursively in the Additional Criteria JSON fields (synchronous endpoints ignore them).

@BatchDataAPI
BatchDataAPI merged commit ebe9284 into main Oct 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant