Repository navigation
Fix/xdg session log directory - #169
Draft
marcoallegretti wants to merge 2 commits into
Draft
marcoallegretti wants to merge 2 commits into
marcoallegretti wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
Store session logs under
$XDG_STATE_HOME/shoji_wm/logs/, falling back to~/.local/state/shoji_wm/logs/. Ignore empty or relativeXDG_STATE_HOMEvalues. Add
SHOJI_LOG_DIRto override the complete directory; emptyoverrides are ignored.
Timescope profiles use the same resolver. Rotation and retention remain
unchanged and operate within the selected directory.
The default-path change does not migrate or delete files under
~/shoji_wm/logs/. Selecting that directory withSHOJI_LOG_DIRpreservesthe old location, with normal rotation and retention applying there.
Update English/Japanese documentation and the profiler SDK comment.
API impact:
SHOJI_LOG_DIR.Validation:
behavior.
cargo test -p shojiwm_lib --lib --locked log_path_tests:3 parent tests and 13 child executions passed.
These verify environment precedence, flushed log contents, real Timescope
reports containing a recorded sample, profile rotation, log rotation,
overwrite mode, byte/age retention and preservation of legacy files.
shoji_wmand ran three nested Wayland sessions under headlessWeston with software rendering: XDG, HOME fallback and explicit override.
Each loaded a minimal TypeScript configuration, answered a Wayland
registry/sync request, acknowledged quit and exited with status 0.
Session logs and shutdown profiler reports were verified at each path.
npm run typecheck: passed.npm --prefix docs run build: English and Japanese builds passed.git diff --check: passed.Both failures are unchanged Xwayland socket tests that cannot prepare
/tmp/.X11-unixbecause it is not writable.The existing Scene3D warnings are addressed separately by #167.
This branch starts at main and does not depend on #167 or #168.
Nested validation covers software Wayland with a minimal configuration,
not hardware DRM presentation or visual correctness.