Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 59.79% 61.14% +1.34%
==========================================
Files 22 23 +1
Lines 3878 4002 +124
==========================================
+ Hits 2319 2447 +128
+ Misses 1559 1555 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tvpeter
changed the title
tvpeter
changed the title
tvpeter
force-pushed
the
fix/apply-proxy-config
branch
2 times, most recently
from
September 28, 2026 19:36
cd46c76 to
b2317a8
Compare
vadim-anfv
approved these changes
Oct 1, 2026
vadim-anfv
left a comment
vadim-anfv
left a comment
Collaborator
There was a problem hiding this comment.
ACK b2317a8
The suggestions I left inline are subjective and optional. The one about the unreachable :-containing env var names is a real bug, but it predates this PR.
Nice that the tests assert both directions, proxy contacted and server not.
`--proxy` accepted proxy_opts for both electrum and esplora clients but did not use them during connection. This fix updates both clients to use the provided proxy options during connection - added test for connection through proxy - updated CHANGELOG
- The cbf arm of new_blockchain_client was ignored proxy_opts but bdk_kyoto 0.17.0 support a proxy. This change adds the connection through socks5 proxy. - add tests coverage for cbf connection through socks5 proxy
Several `#[arg(env = "...")]` attributes mistakenly used colons (e.g., `ADDRESS:SAT`) following value-shape documentation conventions. Because colons are invalid in POSIX environment variable names, these fallbacks could never actually be set by users. Renamed these environment variables to use valid identifiers while keeping the flag names and expected value shapes unchanged. Also, format integration tests
tvpeter
force-pushed
the
fix/apply-proxy-config
branch
from
October 2, 2026 05:16
b2317a8 to
e8fc1e3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The application accepted SOCKS5 proxy options (--proxy, --proxy_auth, --retries, --timeout), persisted them to config.toml, and reloaded them on every subsequent run but never applied them to any blockchain client. This PR updates the proxy options for electrum, esplora and cbf.
Fixes #328
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: