fix(sync): link skills through the project's node_modules - #68
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2c1c476 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
import.meta.url resolves to the real path, which under pnpm is a hashed node_modules/.pnpm/<hash>/ directory. Links into it dangle once a reinstall changes the hash.
dreyfus92
force-pushed
the
fix/sync-stable-links
branch
from
September 24, 2026 02:17
83f3f67 to
2c1c476
Compare
dreyfus92
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bsh synccreated skill symlinks into pnpm's content-addressed store:import.meta.urlresolves to the real path, and the.pnpm/<hash>/segment changes whenever the version or peer set changes. Links dangle after a reinstall untilbsh syncruns again.resolveSkillsSourceprefers<project>/node_modules/@bomb.sh/tools/skills/when it exists and falls back to theimport.meta.urlpath otherwise.pruneStaleLinksnow also matches links that target the real path, so links left by older syncs are still cleaned up.Verified against clink:
Independent of #67.