Repository navigation
fix(changelog): the reconcile script leaves out upstream entries the fork removed - #524
Merged
Merged
Conversation
… fork removed; drop eight doubled sync entries scripts/changelog-reconcile.mjs added back every upstream [Unreleased] entry the fork lacked, so an entry the fork had removed or reworded came back on each upstream merge. An entry the merge base's [Unreleased] already had is now left out and listed. Also removes the second copy of eight sync entries that the 5da4a41 merge doubled in [Unreleased].
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[Medium impact] The PR appears safe to merge. SummaryThe reconcile script now preserves fork removals instead of restoring unchanged upstream entries.
No actionable issues were found. Review checks were static; tests were not run. Reviews (1) · Last reviewed commit: "fix(changelog): the reconcile script lea..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next upstream merge no longer brings back changelog entries the fork removed or reworded, and eight doubled entries are gone from
[Unreleased].Problem
scripts/changelog-reconcile.mjsadded every entry in upstream's[Unreleased]that the fork's did not have. An entry the fork had removed or reworded came back on each upstream merge, so each reconcile needed a manual override. Run against the current fork and upstreambaf19067, it would re-add four such entries (VB.NET type lookup, CRLF store export, the C++std::unique_ptrcall, the C++ string-literal declaration).codegraph syncand the file watcher …" entries appeared twice in[Unreleased]> Fixes. Upstream's own changelog already had both copies at the5da4a41dreconcile (merge: reconcile upstream through 5da4a41d #499); upstream has since removed its copies, so the fork's second copies were left over.Change
[Unreleased]already had and the fork lacks, and prints it asleft out. An entry new since the merge base is still added, and with no merge base nothing is skipped.[Unreleased]has no repeated entry and equals the script's rebuild againstupstream/main.codegraph-build-validationnotes theleft outline.Checks
On head
fad31b0a:fork-tooling-scripts.test.ts(dropped entry stays out, new one is added, no base re-adds)fork-tooling-scripts,readme-sync,prepare-releasecheck:agent-docsHEADandupstream/mainbefore the changeREADME rows checked
None: no user-visible behavior, number or README table changes.
Not covered
left outlist is where to spot that.Summary by cubic
The changelog reconcile script no longer re-adds upstream entries the fork removed or reworded, and the eight doubled
codegraph syncand the file watcher entries are gone from[Unreleased].An upstream
[Unreleased]entry that the merge base's[Unreleased]already had and the fork lacks is now skipped and reported asleft out, instead of coming back on every upstream merge and needing a manual override. Entries new since the merge base are still added; with no merge base, nothing is skipped.Written for commit fad31b0. Summary will update on new commits.