Repository navigation
General: keep five significant digits from an exponent of ±99 on - #108
Merged
Merged
Conversation
Part of borgar#105 (point 2) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: For a three-digit exponent, Excel's General format writes five significant digits in the mantissa, not six. For example,
1.23456789E+99gives1.2346E+99in Excel and1.23457E+99in numfmt. This is point 2 of #105.Fix (
src/general.ts,getExp): the mantissa is rounded to 4 decimals when|exp| >= 99, and to 5 otherwise. A mantissa that rounds to 10 is carried into the exponent (9.999994E+200→1E+201). The carry is the same hunk as #106. If #106 merges first, this PR is left with only the digit change.Tests: added a case to
test/ssf-general.spec.tswith the issue's table: ±98 still gives six digits, and +99, +307, −200, +200 (with carry) and −99 (with carry) give five. It fails before the fix and passes after. The fullnpm testsuite, eslint and tsc are clean.Not included: point 3, a subnormal number written as
0. The existing test for #64 expectsGeneralof2.33e-321to give2.33E-321, so that change needs the maintainer to decide first.Part of #105 (point 2; point 1 is #106).
AI-assisted (Claude); reviewed before submission.