Repository navigation
Skip -/+ swaps for unary ops in match-case patterns - #589
Open
GhostCoder6969 wants to merge 1 commit into
Open
GhostCoder6969 wants to merge 1 commit into
GhostCoder6969 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #583.
Mutating case -2 produced case +2, which is a syntax error, so the mutant could never run. Unary plus just is not valid in patterns. The fix tracks unary operations inside match case patterns and skips the operator swap for those nodes only. Everything else still mutates like before, x = -2 still gets its +2 mutant since that one is fine.
I added a regression test that checks no +2 mutant comes out of a match case and that every generated mutant compiles. The test fails on unpatched code and passes with the fix, and the mutation suite shows no new failurs.