Skip to content

minor maintenance on fish example - #121

Merged
IgorTatarnikov merged 5 commits into
mainfrom
fix-fish-example
Nov 5, 2026
Merged

IgorTatarnikov merged 5 commits into
mainfrom
fix-fish-example

Conversation

@alessandrofelder

@alessandrofelder alessandrofelder commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

examples/mpin_api.py was failing locally for me.

What does this PR do?

  • fixes URL to download from
  • makes plot interactive for latest vedo (otherwise renders + immediately closes).

References

Note that previously maybe the intention was to make one plot per neuron, which now changes?

How has this PR been tested?

Ran it locally manually and visually inspected.

Is this a breaking change?

Potentially - see References section above.

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.37%. Comparing base (af93a8d) to head (2a3ee41).

Files with missing lines Patch % Lines
morphapi/api/mpin_celldb.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   72.37%   72.37%           
=======================================
  Files          10       10           
  Lines         724      724           
=======================================
  Hits          524      524           
  Misses        200      200           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessandrofelder
alessandrofelder requested a review from a team November 2, 2026 14:05
- `sorted` to ensure reproducibility across filesytems
- remove function call because already happens in `MpinMorphologyAPI()`
@IgorTatarnikov

Copy link
Copy Markdown
Member

LGTM 🎉

Thanks @alessandrofelder

@IgorTatarnikov
IgorTatarnikov merged commit 0f131ab into main Nov 5, 2026
22 of 23 checks passed
@IgorTatarnikov
IgorTatarnikov deleted the fix-fish-example branch November 5, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants