Repository navigation
Fix the Alexa "today" test failing every Dependabot run - #246
Merged
Merged
Conversation
test_when_speech_today built its date as now + 2 hours, which is tomorrow's date after 10pm in TIME_ZONE (America/Los_Angeles). Dependabot's weekly runs start around 06:00 UTC -- 10-11pm Pacific -- so they failed here every time (Sep 24, Oct 1, Oct 8) while the same branches passed when rerun during the day. Use today's local date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dependabot PR #245 fails CI on one test, and it isn't the dependency bump:
The test built its date as
now + 2 hours. After 10pm inTIME_ZONE(America/Los_Angeles), that's already tomorrow's date. Dependabot's weekly runs start around 06:00 UTC, which is 10–11pm Pacific, so every one of them failed on this test:'Today' not found in 'Tomorrow, September 24''Today' not found in 'Tomorrow, October 1''Today' not found in 'Tomorrow, October 8'The same Oct 1 Dependabot branch passed when it was rerun at 20:14 UTC.
when_speechitself is correct.Fix
Use
timezone.localdate(), today's date in local time.Test plan
alexatests pass (24)when_speechtreats as todayAfter this merges,
@dependabot rebaseon #245 should turn it green. Its other 234 tests already passed with the bumped versions, including thesubscriptions/listenguard onmcp2.3.0.🤖 Generated with Claude Code