Repository navigation
Log only slow or failed MCP requests - #248
Merged
Merged
Conversation
#242's per-POST log found its cause (subscriptions/listen, fixed in #243) and has shown none since: over Oct 6-12, every Claude request finished in under 0.32s. It still writes ~2,500 lines a day, mostly an uptime monitor's pings. Keep it as a cheap early warning instead: the "slow" snapshot at 5s, plus a "done" line only for requests that were slow, ended in a 5xx or no response, or raised. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#242's per-POST log found the 21s stalls (a
subscriptions/listenstream, fixed in #243). From Oct 6 to 12 it recorded none: every Claude request finished in under 0.32s. It still writes about 2,500 lines a day, mostly an uptime monitor'spings.What
log_mcp_requestskeeps the"stage": "slow"snapshot at 5s. It now writes a"done"line only for requests that were slow, ended in a 5xx or with no response, or raised. Fast, successful requests log nothing. It stays in place as a cheap early warning in case a future protocol change brings in another long-lived request.Test plan
mcp_svcpasses (27 tests)🤖 Generated with Claude Code