fix: clean up channels when gateway startup fails - #340
Open
Kunyanli230 wants to merge 1 commit into
Open
Kunyanli230 wants to merge 1 commit into
Kunyanli230 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a channel fails during gateway startup,
ChannelManager.listen_and_run()exits before reaching its cleanup block. Channels that started earlier keep running, and the framework retains its channel router.Keep startup inside the cleanup scope and stop only channels that started successfully. Startup errors and cancellation still propagate. The regression test also checks router detachment and avoids stopping a channel that was never started.
Validation on Python 3.12:
make checkpassed (lockfile, pre-commit hooks, and mypy).make test: 571 passed, 20 skipped.The Python 3.13/3.14 matrix is left to CI, as permitted by the contribution guide. No CLI or documentation changes.