Repository navigation
fix(release): Homebrew cask clears the quarantine flag - #114
Merged
Merged
Conversation
Homebrew quarantines what a cask downloads and Gatekeeper kills a quarantined binary that is not notarized, so the cask's c3x exited 137 on launch. Generate a postflight_steps block that removes the flag (hooks would emit the deprecated postflight), and fix the desc/homepage that brew style flagged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
brew install c3xdev/tap/c3xinstalled a c3x that macOS killed on launch (exit 137). Homebrew quarantines what a cask downloads, and Gatekeeper rejects a quarantined binary that isn't notarized. Ours is ad-hoc signed only (spctl: rejected). The same binary runs once the flag is removed.Fix:
custom_blockgeneratespostflight_stepsthat runsxattr -dr com.apple.quarantine c3xon macOS.hookswould emitpostflight do, which Homebrew 7 deprecates in favour ofpostflight_steps.brew style.Tested on macOS arm64 with Homebrew 7.0.9:
goreleaser checkpasses, and a snapshot release generates the block.c3x --versionandc3x doctorrun;brew audit --cask --strict --onlinepasses.custom_blockfirst, sobrew stylereports stanza order. That's cosmetic: audit and install pass.c3xdev/homebrew-tap@60ac887 already fixes the published 0.3.20 cask (cleanly ordered,
brew styleclean). I verified it with a freshbrew installfrom GitHub.Longer term, signing and notarizing the macOS binaries with an Apple Developer ID would remove the need for this.