You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Records on-demand REQ, COUNT, and NEG-OPEN requests and the events served
for each authenticated peer pubkey in Redis. The admin console's Peering table
shows the request and event-served counts per peer, and the diagnostics export
includes the same counters. Accounting is best-effort and never fails the
request it describes.
Summary by CodeRabbit
New Features
Admin Peering tables and diagnostics exports now include per-peer counts for on-demand requests and events served. Recording these counts does not interrupt the request being handled.
No actionable comments were generated in the recent review.
Walkthrough
The changes add a 3.14.0 changelog entry describing per-peer request and served-event counters, update the package version to 3.14.0, and remove the corresponding changeset.
Changes: Release metadata
Layer / File(s)
Summary
Release entry and package version CHANGELOG.md, package.json, .changeset/peering-request-admin.md
The changelog describes per-authenticated-peer on-demand request and served-event counters, and states that accounting is best-effort. The package version changes to 3.14.0, and the corresponding changeset is removed.
cameri/nostream#1059: Implements the peer request and event accounting described in this release entry.
cameri/nostream#1055: Implements per-peer on-demand request limits and defers request accounting to a follow-up.
Merge Risk: Minimal · up to 1022c
The release records the peer-accounting changes for version 3.14.0. No merge-blocking risk was identified.
Architecture risk: Low · up to 1022c
The change affects 2 systems.
Changed systems:CHANGELOG.md, package.json
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — CHANGELOG.md (service) was modified; 1 changed file maps to changed impact.
observed — package.json (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in CHANGELOG.md: Adds the 3.14.0 Minor Changes entry describing per-authenticated-peer on-demand request and served-event counters in the admin Peering table and diagnostics export; accounting is best-effort and does not fail the corresponding request.
observed — Modified behavior in package.json: The package version changes from 3.13.0 to 3.14.0.
observed — Modified behavior in .changeset/peering-request-admin.md: Removed the nostream minor changeset entry and its description of per-peer request and event-served counters in Redis, the admin Peering table, and diagnostics export, including the claim that accounting does not fail the described request.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title identifies the release, which is the main purpose of the pull request. It does not specify version 3.14.0.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit reads the release note bright, Three fourteen hops into sight. Peer counts are named in the changelog, The version follows, clear as a log. The old changeset slips away, And I nibble carrots to celebrate today.
Recent review info
Automatic approval policy
Commit: 1022c133405a.
Setting
Effective value
Source
Automatic approvals
Enabled
Global configuration
Merge risk
Minimal
Global configuration
Security risk
Not set
Global configuration
Not set means no limit was configured after inheritance. Use @coderabbitai configuration to inspect the resolved settings and their sources.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 5abd990c-2f2d-4d35-8ed7-70600b028b86
Commits
Reviewing files that changed from the base of the PR and between 87bc6c8 and 1022c13.
Files selected for processing: 3
.changeset/peering-request-admin.md
CHANGELOG.md
package.json
Files with no reviewable changes: 1
.changeset/peering-request-admin.md
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
nostream@3.14.0
Minor Changes
#1059
dfcc967Thanks @Ferryx349! - feat(admin): account for peer on-demand requestsRecords on-demand
REQ,COUNT, andNEG-OPENrequests and the events servedfor each authenticated peer pubkey in Redis. The admin console's Peering table
shows the request and event-served counts per peer, and the diagnostics export
includes the same counters. Accounting is best-effort and never fails the
request it describes.
Summary by CodeRabbit