Skip to content

chore: release new version 🚀 - #1076

Merged
cameri merged 1 commit into
mainfrom
changeset-release/main
Nov 7, 2026
Merged

cameri merged 1 commit into
mainfrom
changeset-release/main

Conversation

@cameri

@cameri cameri commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

nostream@3.15.1

Patch Changes

  • #1075 4b4b247 Thanks @chappie-daemon! - Admission now runs inside a serializable transaction. admit_user() opens with PERFORM ASSERT_SERIALIZED(), so calling it on the default read-committed connection raised SN_NOT_SERIALIZABLE and every NIP-43 join request failed. A caller that supplies its own client (the payments path) still runs inside the transaction it passes.

Summary by CodeRabbit

  • Bug Fixes
    • User admission now works with the default database connection, preventing NIP-43 join requests from failing because of transaction isolation settings. When a caller provides its own database client, admission continues to use the caller’s transaction.
  • Release
    • Updated the package version and changelog for version 3.15.1.

@greptile-apps

greptile-apps Bot commented Nov 7, 2026

Copy link
Copy Markdown

This PR does not match any of the 1 configured review trigger rule.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

This release updates the package version to 3.15.1, adds a changelog entry about admit_user() transaction behavior, and removes the corresponding changeset.

Changes: 3.15.1 release

Layer / File(s) Summary
Publish release metadata
CHANGELOG.md, package.json, .changeset/admit-serializable-transaction.md
The changelog describes the serializable transaction behavior and the prior SN_NOT_SERIALIZABLE failure affecting NIP-43 join requests. The package version changes to 3.15.1, and the changeset is removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Medium

Possibly related PRs

Merge Risk: Minimal · up to f1bda

This release only changes metadata: the version, the changelog, and the removed changeset. It documents the already-implemented fix that lets NIP-43 join requests succeed. It is ready to merge. If npm publication was actually intended, the maintainers should confirm that, because the package is still marked private.

Architecture risk: Low · up to f1bda

The change affects 2 systems.

Changed systems: CHANGELOG.md, package.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CHANGELOG.md (service) was modified; 1 changed file maps to changed impact.
  • observed — package.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CHANGELOG.md: Adds the 3.15.1 release entry describing the serializable transaction requirement for admit_user(), the prior failure on the default read-committed connection and its effect on NIP-43 joins, and continued use of the supplied transaction when a caller provides its own client.
  • observed — Modified behavior in package.json: The package version changes from 3.15.0 to 3.15.1.
  • observed — Modified behavior in .changeset/admit-serializable-transaction.md: The changeset declaring a nostream patch release and describing admission’s serializable-transaction behavior was removed.
Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "chore: release new version 🚀" is generic. It does not name the change. The PR is a Changesets release that bumps nostream from 3.15.0 to 3.15.1. The actual change is that admit_user() now r… Replace the title with one that names the main change. For example: "chore: release nostream 3.15.1" or "fix: run admit_user in a serializable transaction (3.15.1 release)". Remove the emoji.
Passed Passed checks: 4 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Title check

Explanation

The title "chore: release new version 🚀" is generic. It does not name the change. The PR is a Changesets release that bumps nostream from 3.15.0 to 3.15.1. The actual change is that admit_user() now runs in a serializable transaction, which fixes NIP-43 join requests failing with SN_NOT_SERIALIZABLE. The title does refer to a real aspect of the changeset (the version release), so it is not unrelated. It is still too vague to tell a reader what changed.

Resolution

Replace the title with one that names the main change. For example: "chore: release nostream 3.15.1" or "fix: run admit_user in a serializable transaction (3.15.1 release)". Remove the emoji.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit reads the changelog by moonlight,
Then marks version three point fifteen point one.
The join request hops past its old error,
While serializable paths keep their course.
The changeset rests; the release is done.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

package.json-5-5: 1

5-5: Major · Data Integrity & Integration · Heavy lift

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Enable npm publication for this release.

nostream is marked private, so changeset publish skips it. The private-package tag setting can create a Git tag, but it does not publish version 3.15.1 to npm. Remove the private flag and configure authenticated npm publishing if npm publication is intended. (raw.githubusercontent.com)

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c0fa722-76f2-4822-8cec-410ef029f809
Commits

Reviewing files that changed from the base of the PR and between 0d47b89 and f1bda62.

Files selected for processing: 3

  • .changeset/admit-serializable-transaction.md
  • CHANGELOG.md
  • package.json
Files with no reviewable changes: 1

  • .changeset/admit-serializable-transaction.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@cameri
cameri enabled auto-merge November 7, 2026 20:34
@cameri
cameri merged commit 92a34ad into main Nov 7, 2026
15 checks passed
@cameri
cameri deleted the changeset-release/main branch November 7, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant