Skip to content

Remove scene default from priority dropdown for pp volumes and add clamp - #136

Merged
Ikreb1 merged 2 commits into
mainfrom
pp-override-chooser
Oct 29, 2026
Merged

Ikreb1 merged 2 commits into
mainfrom
pp-override-chooser

Conversation

@Ikreb1

@Ikreb1 Ikreb1 commented Oct 29, 2026

Copy link
Copy Markdown
Member

Summary

Users were accidentally using scene default for their low prio pp volumes causing clashing with the base scene pp, so I thought we should hid it from the so we can protect them from themselves. Not exactly sure if this is needed so swat me down if needed ccp nobody.

Testing

tested in graphite

AI assistance

yeah, AI assisted

@Ikreb1
Ikreb1 requested review from CCPNobody and a balanced review from Copilot October 29, 2026 10:21
@Ikreb1
Ikreb1 force-pushed the pp-override-chooser branch from 264943e to a5732b1 Compare October 29, 2026 10:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the changes restricting override priorities to the Low–UI range.

No open issues 🎉

What changed in this PR

This PR reserves scene-default priority for base scene post-processing by removing it from override dropdowns and clamping override priorities at runtime.

Changes:

  • Adds an override-specific priority chooser containing Low, Medium, High, and UI.
  • Applies the chooser to post-process attributes and lighting overrides.
  • Clamps post-process volume and lighting override priorities to the Low–UI range.
File Description
trinity/​PostProcess/​Tr2PostProcessEnums.h Declares the override chooser and adds a shared priority clamp.
trinity/​PostProcess/​Tr2PostProcessAttributes_Blue.cpp Defines the restricted chooser and uses it for post-process attributes.
trinity/​Eve/​SpaceObject/​Children/​EveChildPostProcessVolume.cpp Clamps priority when retrieving volume attributes.
trinity/​Eve/​SpaceObject/​Children/​EveChildLightingOverride.cpp Clamps lighting override priority during asynchronous updates.
trinity/​Eve/​SpaceObject/​Children/​EveChildLightingOverride_Blue.cpp Switches the lighting override dropdown to the restricted chooser.

Review effort: Balanced

@CCPNobody

CCPNobody commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

I think this is a bit overkill. You could just remove the SCENE_DEFAULT thing from the blue exposure.
@Ikreb1

@Ikreb1
Ikreb1 merged commit 8e2e498 into main Oct 29, 2026
13 checks passed
@Ikreb1
Ikreb1 deleted the pp-override-chooser branch October 29, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants