Repository navigation
Remove scene default from priority dropdown for pp volumes and add clamp - #136
Merged
Merged
Conversation
…the output so python cant override it
Ikreb1
force-pushed
the
pp-override-chooser
branch
from
October 29, 2026 10:22
264943e to
a5732b1
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes restricting override priorities to the Low–UI range.
No open issues 🎉
What changed in this PR
This PR reserves scene-default priority for base scene post-processing by removing it from override dropdowns and clamping override priorities at runtime.
Changes:
- Adds an override-specific priority chooser containing Low, Medium, High, and UI.
- Applies the chooser to post-process attributes and lighting overrides.
- Clamps post-process volume and lighting override priorities to the Low–UI range.
| File | Description |
|---|---|
trinity/PostProcess/Tr2PostProcessEnums.h |
Declares the override chooser and adds a shared priority clamp. |
trinity/PostProcess/Tr2PostProcessAttributes_Blue.cpp |
Defines the restricted chooser and uses it for post-process attributes. |
trinity/Eve/SpaceObject/Children/EveChildPostProcessVolume.cpp |
Clamps priority when retrieving volume attributes. |
trinity/Eve/SpaceObject/Children/EveChildLightingOverride.cpp |
Clamps lighting override priority during asynchronous updates. |
trinity/Eve/SpaceObject/Children/EveChildLightingOverride_Blue.cpp |
Switches the lighting override dropdown to the restricted chooser. |
Review effort: Balanced
Member
|
I think this is a bit overkill. You could just remove the SCENE_DEFAULT thing from the blue exposure. |
CCPNobody
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users were accidentally using scene default for their low prio pp volumes causing clashing with the base scene pp, so I thought we should hid it from the so we can protect them from themselves. Not exactly sure if this is needed so swat me down if needed ccp nobody.
Testing
tested in graphite
AI assistance
yeah, AI assisted