[CCPNobody]

Summary

Space scene: one render path for the main view and the reflection probe faces

• One render path: EveSpaceSceneRenderDriver::RenderView now renders both the main view and each reflection probe face, and the faces render straight into the probe's cube. Scene work is split into per-frame steps (Update, BeginFrame) and per-view steps (BeginView, EndView). The scene's old reflection pass is removed.
• Per-view settings: EveSceneView::Camera and ViewInfo hold the scene's settings for a view, and the driver's Features holds its own.
• Dynamic lights in reflections: lights have a new reflectionMode attribute that picks the reflection qualities they appear in. Tr2LightManager gathers lights once per frame and builds a light list for each view.
• Lens flares in reflections: flare visibility is now worked out for each view. This fixes a flare that also showed up in the face opposite the sun, which happens on main too.
• Profiling stats renamed:
  • The main view's passes are under MainView/, and the faces are under RenderReflections/FaceN/.
  • BeginRender and EndRender are now BeginView and EndView, and there's a new BeginFrame.

AI assistance

AI helped

[Copilot]

🟡 Changes recommended

Unresolved rendering regressions can leave camera and post-process state incorrect, make camera-attached objects lag, and let reflection passes overwrite the main view’s occlusion history.

6 open issues

• Refresh post-process settings on same-frame updates · New
• Preserve camera initialization for direct update entry points · New
• Update camera-attached transforms before gathering renderables · New
• Restore view camera after background node rendering · New
• Gate occlusion queries to temporal main views · New
• Avoid normal maps for raytraced shadows in reflections · New

What changed in this PR

Unifies main-view and reflection-probe rendering in the space-scene driver, separating per-frame updates from per-view rendering.

Changes:

• Renders reflection faces directly into the probe cubemap through the shared render path.
• Adds per-view light lists, reflection-quality filters, and lens-flare visibility updates.
• Introduces explicit view settings, extracts projection jitter generation, and reorganizes profiling timers.

File	Description
trinity/​Tr2ReflectionProbe.h	Exposes face cameras, cube target, and filtering API.
trinity/​Tr2ReflectionProbe.cpp	Removes intermediate face targets and adapts filtering.
trinity/​Tr2LightManager.h	Defines reflection quality and per-view light storage.
trinity/​Tr2LightManager.cpp	Gathers, filters, and uploads lights per view.
trinity/​PostProcess/​Tr2PostProcessRenderer.h	Declares reusable projection jitter helper.
trinity/​PostProcess/​Tr2PostProcessRenderer.cpp	Implements projection jitter generation.
trinity/​Lights/​Tr2TexturedPointLight_Blue.cpp	Exposes textured-light reflection filtering.
trinity/​Lights/​Tr2SpotLight_Blue.cpp	Exposes spotlight reflection filtering.
trinity/​Lights/​Tr2PointLight_Blue.cpp	Exposes point-light reflection filtering.
trinity/​Lights/​Tr2Light.h	Adds light reflection tags and chooser declaration.
trinity/​Lights/​Tr2Light.cpp	Passes reflection tags to the light manager.
trinity/​Lights/​Tr2Light_Blue.cpp	Registers reflection-quality filter options.
trinity/​Lights/​Tr2FactionLight_Blue.cpp	Exposes faction-light reflection filtering.
trinity/​Eve/​EveSpaceSceneRenderDriver.h	Defines shared rendering structures and per-view timers.
trinity/​Eve/​EveSpaceSceneRenderDriver.cpp	Coordinates frame setup and shared view rendering.
trinity/​Eve/​EveSpaceScene.h	Declares frame/view lifecycle and camera APIs.
trinity/​Eve/​EveSpaceScene.cpp	Separates frame updates from view-specific scene work.
trinity/​Eve/​EveSceneView.h	Defines camera and scene-view settings.
trinity/​Eve/​EveSceneView.cpp	Builds frustums and main/reflection view defaults.
trinity/​CMakeLists.txt	Adds the new scene-view source files.

_{Review effort: Balanced}

[github-actions]

Cpp-linter Review

Used clang-format v21.1.8

Click here for the full clang-format patch

diff --git a/trinity/Eve/EveSpaceScene.cpp b/trinity/Eve/EveSpaceScene.cpp
--- a/trinity/Eve/EveSpaceScene.cpp
+++ b/trinity/Eve/EveSpaceScene.cpp
@@ -1356 +1356 @@ void EveSpaceScene::BeginFrame( Tr2RenderContext& renderContext )
-	// Ensure that the camera attachment parent is updated to the current view transform, 
+	// Ensure that the camera attachment parent is updated to the current view transform,
diff --git a/trinity/Eve/EveSpaceScene.h b/trinity/Eve/EveSpaceScene.h
--- a/trinity/Eve/EveSpaceScene.h
+++ b/trinity/Eve/EveSpaceScene.h
@@ -149 +149 @@ public:
-	void BeginFrame( Tr2RenderContext& renderContext );
+	void BeginFrame( Tr2RenderContext & renderContext );
@@ -153 +153 @@ public:
-	void PopulateAndApplyPerFrameData( Tr2RenderContext& renderContext );
+	void PopulateAndApplyPerFrameData( Tr2RenderContext & renderContext );
@@ -614 +614 @@ protected:
-	void GatherDynamicLights( Tr2RenderContext& renderContext );
+	void GatherDynamicLights( Tr2RenderContext & renderContext );
@@ -616,2 +616,2 @@ protected:
-	void GatherSceneObjectRenderables( std::vector<IEveSpaceObject2*>& allObjects, std::vector<ITr2Renderable*>& renderables, Tr2RenderContext& renderContext );
-	void GatherReflectionRenderables( std::vector<ITr2Renderable*>& renderables );
+	void GatherSceneObjectRenderables( std::vector<IEveSpaceObject2*> & allObjects, std::vector<ITr2Renderable*> & renderables, Tr2RenderContext & renderContext );
+	void GatherReflectionRenderables( std::vector<ITr2Renderable*> & renderables );
@@ -619 +619 @@ protected:
-	
+
diff --git a/trinity/Eve/EveSpaceSceneRenderDriver.h b/trinity/Eve/EveSpaceSceneRenderDriver.h
--- a/trinity/Eve/EveSpaceSceneRenderDriver.h
+++ b/trinity/Eve/EveSpaceSceneRenderDriver.h
@@ -156 +156 @@ private:
-	ReflectionFaces PrepareReflectionFaces( Tr2RenderContext& renderContext );
+	ReflectionFaces PrepareReflectionFaces( Tr2RenderContext & renderContext );

---

_{✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback}