Repository navigation
Conversation
added 3 commits
November 13, 2026 22:55
1. Токены multiselect приведены к эталону Figma: 26 замен (геометрия поля 272/10/12/12, размеры sm/lg, состояния, опции, группы, оверлей, иконки), extend.paddingX/paddingY удалены как дубли root-ветки (коллизия G7). 2. Токены multiselect впервые включены в пресет: map-tokens.ts спредит tokens.components.multiselect вместе с multiselectCss, раньше применялась только тема Aura с дефолтами. 3. Добавлен CSS слоя кита (multiselect.ts на dt()): раскладка обёртки label/caption, лейбл, поле с min-width 272 и ограничением max-width 100% против раздувания контентом, focus/invalid ring, readonly, xlarge-мода, FloatLabel по поведению InputText, группы uppercase, шапка панели только с фильтром. 4. API: добавлен captionSeverity (подпись через ExtraCaptionComponent с severity), required работает как NG_VALIDATORS, в floatLabel не передаётся placeholder, showHeader/showToggleAll по референсу Overlay. 5. Stories переделаны по шагу 4a: Default, Error, Disabled, Readonly, Chips, Fluid, FloatLabel — одна сторис один экземпляр; комбинаторные examples/ удалены; хост-компонент фиксирует ширину превью 272px по референсу. 6. Документация API (docs/components-api/multiselect.md) дополнена captionSeverity. Заметки для ревьюеров: - API: новый @input captionSeverity: 'base'|'success'|'warning'|'danger'|'info' = 'base' (не ломает); required стал NG_VALIDATORS-валидатором (пустое поле = invalid, раньше был декоративным); остальные входы без изменений. - Токены: extend.paddingX/paddingY удалены осознанно — в эталоне Figma это та же переменная (один targetVariableId), PrimeUIX схлопывал оба пути в одну CSS-переменную; diff.mjs покажет 2 missing, это ожидаемо. - Токены: option.selectedFocusBackground = bg.neutral.weak.default — намеренное отклонение от эталона (medium.active) по приёмке, история итераций в comp-json/FORM/MultiSelect/CHANGES.md. - Технические детали: showHeader/showToggleAll отключают чекбокс «выбрать всё» (в референсе Overlay его нет); ширина поля в stories фиксирована хост-компонентом с encapsulation: None (scoped-стиль сториса не видит PrimeNG-разметку); поле не выходит за фиксированный родитель благодаря max-width: 100% на детях extra-multiselect-body. - Поведение FloatLabel приведено к InputText: в покое лейбл в центре вместо placeholder, при фокусе поднимается (референс Figma рисует статично поднятым — вопрос дизайну зафиксирован).
1. Восстановить 5 исходных example-файлов компонента вместо лишнего удаления. 2. Согласовать примеры с актуальными типами и API, сохранив исходные описания. 3. Проверить snippets текущих stories, изменённые Controls и строгую Angular-компиляцию восстановленных примеров. Заметки для ревьюеров: - Область: только примеры и stories multiselect; производственные компоненты и токены в этом коммите не меняются. - Stories: сохранён текущий список отдельных примеров; исходные example-файлы доступны рядом с ним. - Проверки: Angular-компиляция восстановленных примеров и обязательные gates snippets и описаний проходят.
1. parameters.controls.expanded = true — панель Controls показывает описание, тип, дефолт и группы категорий. 2. Гейты: controls 33/33, descriptions 31/31, source 7/7.
khaliulin
force-pushed
the
feature/form-multiselect-figma-sync
branch
from
November 18, 2026 12:43
33e6739 to
3236651
Compare
Включает глобальный controls.expanded в .storybook/preview.ts (иначе на ветке панель Controls остаётся компактной до мержа инфраструктурной ветки).
khaliulin
force-pushed
the
feature/form-multiselect-figma-sync
branch
from
November 18, 2026 12:45
3236651 to
1f671a2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultiSelect is synced with Figma UI Kit (DS) v2.1: component tokens are aligned with the reference export and wired into the preset for the first time (previously only the Aura theme defaults were applied), a kit CSS layer on
dt()is added, the API gainscaptionSeverity, and stories follow the one-story-per-Figma-preset rule.Changes
tokens.json: 26 multiselect token replacements from the reference (field geometry, sm/lg sizes, states, options, groups, overlay, icons);extend.paddingX/paddingYremoved as duplicates of the root branch.map-tokens.ts: spreadtokens.components.multiselecttogether withmultiselectCss— component tokens reach the preset for the first time.tokens/components/multiselect.ts: label/caption wrapper layout, field (min-width 272, max-width 100%), focus/invalid ring, readonly, DS xlarge mode, FloatLabel, uppercase groups.multiselect.component.ts:captionSeverityviaExtraCaptionComponent,requiredas NG_VALIDATORS, placeholder suppressed in float mode,showHeader/showToggleAllper the Overlay reference.docs/components-api/multiselect.md:captionSeverityadded to the API table.Restore all 5 original example component files. Apply only the typing/API compatibility changes needed to compile them against the current component. Keep existing descriptions verbatim and keep the current single-instance story list.
Keep Show code limited to the displayed instance and update it when Controls change. Restore existing story and Control descriptions verbatim from main.
API changes
captionSeverity:ExtraCaptionSeverity('base' | 'success' | 'warning' | 'danger' | 'info'), default'base'. Thecaptiontext is rendered byExtraCaptionComponentwith a severity icon.required:boolean, defaultfalse— now an NG_VALIDATORS validator (an empty field makes the FormControl invalid; previously the input was decorative). Backward compatible.size="xlarge": rendered per the DS xlarge mode (font 20 / line-height 26 / icon 20 / height 56) — PrimeNG has no xlg, thep-multiselect-xlgclass is layered on top of large.Technical notes for reviewers
extend.paddingX/paddingYremoved: in the Figma reference they are the same variable (a singletargetVariableId), and PrimeUIX collapses both paths into one CSS variable--p-multiselect-padding-x/y(gate G7).diff.mjsshows 2missingentries — expected.option.selectedFocusBackground=bg.neutral.weak.default— a deliberate deviation from the reference (medium.active) accepted during review; the iteration history lives incomp-json/FORM/MultiSelect/CHANGES.md.MultiSelectStoryHostComponent(encapsulation: None — a scoped story style cannot reach PrimeNG markup); the component itself follows the Figma canon:min-width272, grows with the container,fluidstretches it, but never wider than the parent (max-width: 100%on the body wrapper children).showHeader = showFilter,showToggleAll = false— the Overlay reference only has the filter, without a select-all checkbox.Visual changes
fg.defaultinstead of white; focused —weak.default#f0f0f1.Verification
Gates:
check-component multiselect✓ (G1–G8),check-stories-bg/single/controls✓;check-figma-valueslight/dark ✓ for the field, 1 documented deviation for the Option (selectedFocusBackground);check-dt-refs— clean for multiselect.Storybook: 7 stories checked in light and dark, the API-TESTS.md matrix — all rows pass (comp-json/FORM/MultiSelect/API-TESTS.md), no console errors;
test-storybook297/297.Not verified:
npm run lint—@angular-eslint/builderis not installed in this branch; style snapshots (UPDATE_STYLE_BASELINES) — the infrastructure lives inorigin/storybook-style-snapshotsand is not merged.PASS (example restoration): targeted strict Angular template compilation of all 5 restored examples; check-stories-bg; check-stories-source for the full current story list and changed Controls; check-stories-descriptions against origin/main; check-stories-single and check-stories-controls.
The restored standalone files remain available as source examples; restoring them does not add combinatorial stories to the current Storybook index.
Known issues and open questions
selectedFocusBackground=weak.default— deviation from the reference, accepted during review; design confirmation is desirable.Stack
Base: feature/form-caption-figma-sync (#193). Stack: tokens-base (#192) ← caption (#193) ← multiselect (this PR).