Conversation
SemMulder
commented
Sep 24, 2026
SemMulder
commented
Sep 24, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved cleanup data-retention, delegated-reference, and transaction-notification issues block approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Adds optional delegation support with status synchronization, event handling, database tracking, and cleanup integration.
Changes:
- Adds delegation routes and background reporting.
- Propagates submission status notifications.
- Adds external-task migrations and dependency updates.
- Refactors cleanup and extension APIs.
Review findings:
- Critical (4 votes): Cleanup can delete submissions still referenced by delegated tasks.
- Moderate (1 vote): Chunk cleanup leaves completed and failed chunk rows.
- Moderate (3 votes): Submission cleanup leaves terminal chunk payloads.
- Critical (2 votes): Delegation notifications may be broadcast before transactions commit.
| File | Summary |
|---|---|
workspace-hack/Cargo.toml |
Updates shared dependency features. |
opsqueue/src/server.rs |
Registers delegation routes and status channels. |
opsqueue/src/producer/server.rs |
Emits delegation status changes. |
opsqueue/src/lib.rs |
Exposes the delegation module. |
opsqueue/src/delegation/server.rs |
Implements delegation APIs and background reporting. |
opsqueue/src/delegation/mod.rs |
Registers the delegation server module. |
opsqueue/src/db/mod.rs |
Adds a test database-pool helper. |
opsqueue/src/consumer/server/mod.rs |
Emits status changes on chunk completion and failure. |
opsqueue/src/config.rs |
Adds delegation server URL configuration. |
opsqueue/src/common/submission.rs |
Adds status notifications and cleanup changes. |
opsqueue/src/common/mod.rs |
Registers extension support. |
opsqueue/src/common/extension.rs |
Adds extension and core APIs. |
opsqueue/src/common/chunk.rs |
Adds status notifications and chunk deletion helpers. |
opsqueue/migrations/20260811150000_submissions_external_task.up.sql |
Creates external-task storage. |
opsqueue/migrations/20260811150000_submissions_external_task.down.sql |
Removes external-task storage. |
opsqueue/Cargo.toml |
Adds delegation and test dependencies. |
opsqueue/app/main.rs |
Updates cleanup task initialization. |
Cargo.toml |
Bumps the workspace version. |
Cargo.lock |
Updates locked dependencies and package versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SemMulder
commented
Sep 24, 2026
SemMulder
force-pushed
the
sm/delegation-2
branch
from
September 25, 2026 13:47
a40eb46 to
7d44741
Compare
SemMulder
force-pushed
the
sm/delegation-2
branch
from
September 25, 2026 15:40
7d44741 to
fd4e096
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unimplemented event handling, incorrect terminal-status recovery, and duplicate background workers can produce incorrect external state.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (5)
| self.core_api.clone(), | ||
| self.delegation_server_url.clone(), | ||
| ) | ||
| .run_background() |
Comment on lines
+195
to
+198
| WorkerDelegationEvent::Return(_task_ids) => { | ||
| tracing::info!( | ||
| "Received 'return' delegation event, which is not yet implemented; ignoring." | ||
| ); |
Comment on lines
+486
to
+490
| None => { | ||
| let task_id = &task.task_id; | ||
| let submission_id = &task.submission_id; | ||
| tracing::warn!(%submission_id, %task_id, "Got external task but could not find its submission. This could be a resubmitted external task, where we already cleaned up the corresponding submission after failure/completion. Assuming it completed successfully."); | ||
| DelegatedJobStatus::Completed |
| pub(crate) async fn cancel_submission_notx( | ||
| id: SubmissionId, | ||
| mut conn: impl WriterConnection<Transaction = True>, | ||
| mut conn: impl WriterConnection, |
| .execute(tx.get_inner()) | ||
| .await?.rows_affected(); | ||
| let mut read_conn = db.reader_conn().await?; | ||
| let mut write_conn = db.writer_conn().await?; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.