Skip to content

fix: bump chargebee to 3.35.0 and label auth telemetry with the new site - #29

Merged
cb-muthiahm merged 2 commits into
mainfrom
dependabot/bun/dev-dependencies-1266ed553f
Nov 11, 2026
Merged

cb-muthiahm merged 2 commits into
mainfrom
dependabot/bun/dev-dependencies-1266ed553f

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two fixes, one commit each:

  1. fix(deps): bump chargebee 3.34.0 → 3.35.0. Generated commands come from the installed SDK's endpoint registry, so the bump also regenerates src/commands/generated/ and THIRD_PARTY_NOTICES.txt. Before, the Dependabot-only lockfile change failed test / codegen (drift) and test / test (the notices still named 3.34.0). The OpenAPI specs are unchanged at chargebee/openapi@480b6b1.

     business-entity
    +  create | retrieve | update | list
     invoice
    +  remove-payment-schedule-scheme
     ledger-account-balance
    +  update-overdraft-limit
    +collections-payment-promise   # new resource
    +price-ramp                    # new resource
    +retry-segment                 # new resource (read-only)
  2. fix(telemetry): label auth add / auth switch events with the newly active site (from fix(telemetry): label auth add/switch events with the newly active site #28). The recorder read site_name in preAction, before the action saved the new active profile. A first auth add was reported as unconfigured, and later ones carried the previous profile's site.

     preAction
       begin()      pending.siteName = peekActiveSiteName()
     action (auth add / auth switch)
       writeConfig({ activeProfile })
    +  noteActiveSite(site)
     exit
       finalize()
    -    site_name: pending.siteName
    +    site_name: takeActiveSite() ?? pending.siteName

    noteActiveSite lives in the dependency-free telemetry/active-site.ts, like error.ts and interactive.ts, so commands don't import the recorder. A failed command never reaches the call and keeps its previous label.

Changes

  • package.json floor unchanged; bun.lock resolves chargebee@3.35.0.
  • src/commands/generated/: 3 new resource files; business_entity.ts, invoice.ts, ledger_account_balance.ts, registry.ts, docs-operations.ts updated. New write commands go through the live-site write gate, and PC2-only operations go through the catalog gate.
  • THIRD_PARTY_NOTICES.txt: chargebee@3.35.0.
  • src/lib/telemetry/active-site.ts: new noteActiveSite / takeActiveSite slot.
  • src/lib/telemetry/index.ts: finalize() prefers the noted site; the test reset clears it.
  • src/commands/auth.ts, src/lib/config/switch-profile.ts: note the site once the profile is saved as active.
  • src/lib/test-support/_helpers.ts: runCli accepts an optional configure hook for installing the recorder in integration tests.
  • TELEMETRY.md: documents site_name for auth add and auth switch.

Evidence

  • Before: test / codegen failed with generated-command drift. test / test failed 2 of 1402 tests (THIRD_PARTY_NOTICES.txt expected chargebee@3.35.0).
    After: 1413 pass, 0 fail. Typecheck, coverage gate (99.90% functions, 99.45% lines) and third-party-notices --check all pass.

  • Telemetry integration tests, run against main without the fix:

    Scenario Before After
    First auth add for acme-test unconfigured acme-test
    auth add for globex-test while acme-test is active acme-test globex-test
    auth switch dev (acme-test) from globex-test globex-test acme-test
    auth add with an invalid site while acme-test is active acme-test acme-test

Merge Danger

Door: two-way. Revert either commit independently; no config, credential or stored-data changes.

Blast Radius: additive. New API commands appear in --help; existing commands and flags are unchanged. Telemetry only changes the site_name label on auth add / auth switch events.

Both commits are fix:, so after merge Release Please opens a 1.5.2 release PR.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / internal
  • Other:

Checklist

  • bun test passes
  • bun run typecheck passes
  • If I changed the code generator or SDK version, I ran bun run generate --refresh and committed the regenerated src/commands/generated/*
  • I updated docs / README / skill content where relevant
  • I did not commit any secrets or credentials

Related issues

Supersedes #28. SDK release notes: chargebee-node v3.35.0.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Nov 9, 2026
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 36b4e6f6-2595-40b8-939c-9e74c55e0b82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Test coverage

✅ Gate passed — all 79 files are at or above the 95% floor.

Status Metric Coverage Threshold
✅ Functions 99.90% 95%
✅ Lines 99.45% 95%

Regenerates the API commands and THIRD_PARTY_NOTICES.txt for the new SDK.
Adds business-entity create/retrieve/update/list, invoice
remove-payment-schedule-scheme, ledger-account-balance
update-overdraft-limit, and the collections-payment-promise, price-ramp,
and retry-segment resources. Specs are unchanged at chargebee/openapi@480b6b1.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cb-muthiahm
cb-muthiahm force-pushed the dependabot/bun/dev-dependencies-1266ed553f branch from d4f0a01 to 7017da4 Compare November 10, 2026 12:38
@cb-muthiahm cb-muthiahm changed the title build: bump chargebee from 3.34.0 to 3.35.0 in the dev-dependencies group fix(deps): bump chargebee to 3.35.0 Nov 10, 2026
@cb-muthiahm cb-muthiahm changed the title fix(deps): bump chargebee to 3.35.0 fix: bump chargebee to 3.35.0 and label auth telemetry with the new site Nov 10, 2026
@cb-muthiahm
cb-muthiahm merged commit da82925 into main Nov 11, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants