Repository navigation
fix: bump chargebee to 3.35.0 and label auth telemetry with the new site - #29
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Contributor
Test coverage✅ Gate passed — all 79 files are at or above the 95% floor.
|
Regenerates the API commands and THIRD_PARTY_NOTICES.txt for the new SDK. Adds business-entity create/retrieve/update/list, invoice remove-payment-schedule-scheme, ledger-account-balance update-overdraft-limit, and the collections-payment-promise, price-ramp, and retry-segment resources. Specs are unchanged at chargebee/openapi@480b6b1. Co-authored-by: Cursor <cursoragent@cursor.com>
cb-muthiahm
force-pushed
the
dependabot/bun/dev-dependencies-1266ed553f
branch
from
November 10, 2026 12:38
d4f0a01 to
7017da4
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
cb-logesh
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes, one commit each:
fix(deps): bumpchargebee3.34.0 → 3.35.0. Generated commands come from the installed SDK's endpoint registry, so the bump also regeneratessrc/commands/generated/andTHIRD_PARTY_NOTICES.txt. Before, the Dependabot-only lockfile change failedtest / codegen(drift) andtest / test(the notices still named 3.34.0). The OpenAPI specs are unchanged atchargebee/openapi@480b6b1.fix(telemetry): labelauth add/auth switchevents with the newly active site (from fix(telemetry): label auth add/switch events with the newly active site #28). The recorder readsite_nameinpreAction, before the action saved the new active profile. A firstauth addwas reported asunconfigured, and later ones carried the previous profile's site.preAction begin() pending.siteName = peekActiveSiteName() action (auth add / auth switch) writeConfig({ activeProfile }) + noteActiveSite(site) exit finalize() - site_name: pending.siteName + site_name: takeActiveSite() ?? pending.siteNamenoteActiveSitelives in the dependency-freetelemetry/active-site.ts, likeerror.tsandinteractive.ts, so commands don't import the recorder. A failed command never reaches the call and keeps its previous label.Changes
package.jsonfloor unchanged;bun.lockresolveschargebee@3.35.0.src/commands/generated/: 3 new resource files;business_entity.ts,invoice.ts,ledger_account_balance.ts,registry.ts,docs-operations.tsupdated. New write commands go through the live-site write gate, and PC2-only operations go through the catalog gate.THIRD_PARTY_NOTICES.txt:chargebee@3.35.0.src/lib/telemetry/active-site.ts: newnoteActiveSite/takeActiveSiteslot.src/lib/telemetry/index.ts:finalize()prefers the noted site; the test reset clears it.src/commands/auth.ts,src/lib/config/switch-profile.ts: note the site once the profile is saved as active.src/lib/test-support/_helpers.ts:runCliaccepts an optionalconfigurehook for installing the recorder in integration tests.TELEMETRY.md: documentssite_nameforauth addandauth switch.Evidence
Before:
test / codegenfailed with generated-command drift.test / testfailed 2 of 1402 tests (THIRD_PARTY_NOTICES.txtexpectedchargebee@3.35.0).After: 1413 pass, 0 fail. Typecheck, coverage gate (99.90% functions, 99.45% lines) and
third-party-notices --checkall pass.Telemetry integration tests, run against
mainwithout the fix:auth addfor acme-testauth addfor globex-test while acme-test is activeauth switch dev(acme-test) from globex-testauth addwith an invalid site while acme-test is activeMerge Danger
Door: two-way. Revert either commit independently; no config, credential or stored-data changes.
Blast Radius: additive. New API commands appear in
--help; existing commands and flags are unchanged. Telemetry only changes thesite_namelabel onauth add/auth switchevents.Both commits are
fix:, so after merge Release Please opens a 1.5.2 release PR.Type of change
Checklist
bun testpassesbun run typecheckpassesbun run generate --refreshand committed the regeneratedsrc/commands/generated/*Related issues
Supersedes #28. SDK release notes: chargebee-node v3.35.0.