Skip to content

fix(cli): rename live-site write confirmation flag to --allow-write - #31

Merged
cb-logesh merged 1 commit into
mainfrom
fix/live-write-allow-write
Nov 13, 2026
Merged

cb-logesh merged 1 commit into
mainfrom
fix/live-write-allow-write

Conversation

@cb-muthiahm

@cb-muthiahm cb-muthiahm commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

chargebee customer create --yes doesn't say what you're agreeing to. On API write commands, -y/--yes actually means "run this write on a live (production) site without asking." This PR renames that flag to --allow-write.

To avoid breaking scripts written against v1.5.1, -y/--yes still works on API write commands. It is hidden from help and prints a deprecation warning that names --allow-write. We'll remove it in the next major version.

Changes

  • Generated write commands now take --allow-write. -y/--yes is a hidden, deprecated alias (src/tools/generate.ts, regenerated src/commands/generated/*).
  • ensureWriteAllowed takes { allowWrite, yes }. It warns on stderr when only the deprecated alias is used. The refusal message now points to --allow-write.
  • Updated the README, AGENTS.md, the top-level help, auth add help, and the bundled skill content (SKILL.md, commands.md, workflows.md).
  • Tests: the existing gate tests now use --allow-write. New tests cover the --yes/-y alias with its warning, no warning when --allow-write is passed, and help listing --allow-write while hiding --yes.

Unchanged: -y/--yes on auth remove and skills add/update/remove. There it really is a generic "skip prompts," not a production-write confirmation. Test sites, reads, non-mutating POSTs, and --code-sample behave as before.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / internal
  • Other:

Checklist

  • bun test passes (unit and integration: 1417 pass; per-file coverage gate passes)
  • bun run typecheck passes
  • If I changed the code generator or SDK version, I ran bun run generate --refresh and committed the regenerated src/commands/generated/*
  • I updated docs / README / skill content where relevant
  • I did not commit any secrets or credentials

Related issues

Follow-up to the live-site write confirmation added in v1.5.1.

🤖 Generated with Claude Code

Renames the live-site write confirmation flag from -y/--yes to --allow-write for generated write commands. --yes and -y stay as hidden deprecated aliases that print a warning. Updates ensureWriteAllowed, liveWriteDecision, refusal text, docs, and skill content. auth remove and skills flags are unchanged.

`customer create --yes` does not say what is being agreed to. API write
commands now take --allow-write to confirm a write on a live site without
the prompt. -y/--yes keeps working as a hidden, deprecated alias that
prints a warning naming --allow-write; it will be removed in the next
major version. The -y/--yes on `auth remove` and `skills` is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CLI now uses --allow-write to confirm live-site writes. The deprecated -y and --yes aliases remain supported and produce a warning when used without --allow-write. Tests and guidance reflect the updated flag.

Changes

Live-write confirmation

Layer / File(s) Summary
Confirmation behavior and guidance
src/lib/api/*, src/tools/generate.ts, src/tests/{unit,integration}/..., src/commands/*, src/lib/skills/content/..., AGENTS.md, README.md
Write commands use --allow-write; -y and --yes remain as deprecated aliases. The write gate, tests, command help, and documentation reflect the new flag. Existing refusal conditions remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • chargebee/cli#27: Introduces the live-site write gate and the -y/--yes confirmation flow updated here.

Suggested reviewers: cb-logesh

Merge Risk: Minimal · up to 9c474

The CLI now uses --allow-write to confirm live-site writes, and the old -y/--yes flags still work with a deprecation warning. No merge-blocking risk remains; the docs could optionally mention the deprecated aliases.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 8408ab7c-f78c-4b6e-a3d4-75714eec3009
Commits

Reviewing files that changed from the base of the PR and between da82925 and 9c47471.

Files ignored due to path filters: 63

  • src/commands/generated/addon.ts is excluded by !**/generated/**
  • src/commands/generated/address.ts is excluded by !**/generated/**
  • src/commands/generated/alert.ts is excluded by !**/generated/**
  • src/commands/generated/attached_item.ts is excluded by !**/generated/**
  • src/commands/generated/business_entity.ts is excluded by !**/generated/**
  • src/commands/generated/business_rule.ts is excluded by !**/generated/**
  • src/commands/generated/business_ruleset.ts is excluded by !**/generated/**
  • src/commands/generated/card.ts is excluded by !**/generated/**
  • src/commands/generated/collections_payment_promise.ts is excluded by !**/generated/**
  • src/commands/generated/comment.ts is excluded by !**/generated/**
  • src/commands/generated/coupon.ts is excluded by !**/generated/**
  • src/commands/generated/coupon_code.ts is excluded by !**/generated/**
  • src/commands/generated/coupon_set.ts is excluded by !**/generated/**
  • src/commands/generated/credit_note.ts is excluded by !**/generated/**
  • src/commands/generated/credit_unit.ts is excluded by !**/generated/**
  • src/commands/generated/currency.ts is excluded by !**/generated/**
  • src/commands/generated/customer.ts is excluded by !**/generated/**
  • src/commands/generated/differential_price.ts is excluded by !**/generated/**
  • src/commands/generated/entitlement.ts is excluded by !**/generated/**
  • src/commands/generated/entitlement_override.ts is excluded by !**/generated/**
  • src/commands/generated/feature.ts is excluded by !**/generated/**
  • src/commands/generated/gift.ts is excluded by !**/generated/**
  • src/commands/generated/hosted_page.ts is excluded by !**/generated/**
  • src/commands/generated/in_app_subscription.ts is excluded by !**/generated/**
  • src/commands/generated/invoice.ts is excluded by !**/generated/**
  • src/commands/generated/item.ts is excluded by !**/generated/**
  • src/commands/generated/item_entitlement.ts is excluded by !**/generated/**
  • src/commands/generated/item_family.ts is excluded by !**/generated/**
  • src/commands/generated/item_price.ts is excluded by !**/generated/**
  • src/commands/generated/ledger_account_balance.ts is excluded by !**/generated/**
  • src/commands/generated/ledger_operation.ts is excluded by !**/generated/**
  • src/commands/generated/metered_feature.ts is excluded by !**/generated/**
  • src/commands/generated/non_subscription.ts is excluded by !**/generated/**
  • src/commands/generated/offer_event.ts is excluded by !**/generated/**
  • src/commands/generated/offer_fulfillment.ts is excluded by !**/generated/**
  • src/commands/generated/omnichannel_subscription.ts is excluded by !**/generated/**
  • src/commands/generated/order.ts is excluded by !**/generated/**
  • src/commands/generated/payment_intent.ts is excluded by !**/generated/**
  • src/commands/generated/payment_schedule_scheme.ts is excluded by !**/generated/**
  • src/commands/generated/payment_source.ts is excluded by !**/generated/**
  • src/commands/generated/payment_voucher.ts is excluded by !**/generated/**
  • src/commands/generated/personalized_offer.ts is excluded by !**/generated/**
  • src/commands/generated/plan.ts is excluded by !**/generated/**
  • src/commands/generated/portal_session.ts is excluded by !**/generated/**
  • src/commands/generated/price_ramp.ts is excluded by !**/generated/**
  • src/commands/generated/price_variant.ts is excluded by !**/generated/**
  • src/commands/generated/pricing_page_session.ts is excluded by !**/generated/**
  • src/commands/generated/promotional_credit.ts is excluded by !**/generated/**
  • src/commands/generated/promotional_grant.ts is excluded by !**/generated/**
  • src/commands/generated/purchase.ts is excluded by !**/generated/**
  • src/commands/generated/quote.ts is excluded by !**/generated/**
  • src/commands/generated/ramp.ts is excluded by !**/generated/**
  • src/commands/generated/recorded_purchase.ts is excluded by !**/generated/**
  • src/commands/generated/subscription.ts is excluded by !**/generated/**
  • src/commands/generated/subscription_entitlement.ts is excluded by !**/generated/**
  • src/commands/generated/time_machine.ts is excluded by !**/generated/**
  • src/commands/generated/transaction.ts is excluded by !**/generated/**
  • src/commands/generated/unbilled_charge.ts is excluded by !**/generated/**
  • src/commands/generated/usage.ts is excluded by !**/generated/**
  • src/commands/generated/usage_event.ts is excluded by !**/generated/**
  • src/commands/generated/usage_file.ts is excluded by !**/generated/**
  • src/commands/generated/virtual_bank_account.ts is excluded by !**/generated/**
  • src/commands/generated/webhook_endpoint.ts is excluded by !**/generated/**
Files selected for processing: 12

  • AGENTS.md
  • README.md
  • src/commands/auth.ts
  • src/commands/help.ts
  • src/lib/api/sdk.ts
  • src/lib/api/write-gate.ts
  • src/lib/skills/content/SKILL.md
  • src/lib/skills/content/references/commands.md
  • src/lib/skills/content/references/workflows.md
  • src/tests/integration/live-site-write-gate.test.ts
  • src/tests/unit/lib/api/write-gate.test.ts
  • src/tools/generate.ts
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

Test coverage

✅ Gate passed — all 79 files are at or above the 95% floor.

Status Metric Coverage Threshold
✅ Functions 99.90% 95%
✅ Lines 99.45% 95%

@cb-logesh
cb-logesh merged commit b4eec6f into main Nov 13, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants