You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Each module's strip pass walks all of /app, so the toolchain was still corrupted during the libghostty-vt module. Stripping is off for the manifest; the app binary is stripped on install. A manual release run on this branch built the Flatpak.
Summary by CodeRabbit
Packaging
Updated the Flatpak build so debug information is retained consistently across its components, while the installed app executable is stripped. This changes how build artifacts are handled during packaging without changing the app’s visible features or behavior.
No actionable comments were generated in the recent review.
Walkthrough
The Flatpak manifest now disables stripping and debuginfo globally, removes the Zig module’s local settings, and strips the codeducky binary during installation.
Global build options disable stripping and debuginfo for modules. The Zig module’s duplicate settings are removed. The install command uses install -s to strip the codeducky binary.
charlesabarnes/codeducky#36: Disables stripping and debuginfo for Rust and Zig modules, while this change moves those settings to global build options and strips the app binary during installation.
Merge Risk: Minimal · up to f2ec5
No actionable merge-blocking risk was found in the Flatpak stripping change.
Architecture risk: Low · up to f2ec5
The change affects 1 system.
Changed systems:packaging
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — packaging (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in packaging/flatpak/io.github.charlesabarnes.CodeDucky.yml: Global build-options now disables stripping and debuginfo for all modules; the explanatory comment states that module strip passes affect all of /app and that the app binary is stripped separately.
observed — Modified behavior in packaging/flatpak/io.github.charlesabarnes.CodeDucky.yml: The Zig module’s local strip and debuginfo settings were removed; it now uses the global settings.
observed — Modified behavior in packaging/flatpak/io.github.charlesabarnes.CodeDucky.yml: The codeducky install command now uses install -s to strip the installed binary.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly states the main change: disabling strip passes in Flatpak modules. This matches the manifest changes and PR objective.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 368d0978-9a55-4eb6-b9db-6ed7099af17a
Commits
Reviewing files that changed from the base of the PR and between e092c6a and f2ec544.
Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each module's strip pass walks all of /app, so the toolchain was still corrupted during the libghostty-vt module. Stripping is off for the manifest; the app binary is stripped on install. A manual release run on this branch built the Flatpak.
Summary by CodeRabbit