Repository navigation
Improve Arrow Java ownership and add streaming named parameters - #39
Open
ShawnChen-Sirius wants to merge 2 commits into
Open
ShawnChen-Sirius wants to merge 2 commits into
ShawnChen-Sirius wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Follow-up to #38, which is merged into main. The local-engine build was only for testing; no local-engine package is intended for production.
Note
Add streaming named parameters to Arrow Java and fix reader ownership
ArrowSession.queryArrowgains overloads that accept a named string parameter map; bindings are query-scoped and values are escaped via the JDBC text encoding (ArrowSession.java, ChdbConnection.java)ArrowOptionsgets immutable named choiceswithUnsupportedAsBinary,withLowCardinalityAsDictionary, andwithStringAsBinarythat preserve other settings (ArrowOptions.java)ChdbNative.arrowStreamOpenWithParamsroutes nonempty parameter maps to the core named-parameter API; empty maps use the existing path (chdb_jni.cpp)insertOwnedReadernow takes ownership inside a try-with-resources after the open-session and no-active-query checks, so the reader closes even when table-name or schema validation fails (ArrowSession.java)ChdbNative.JNI_ABI_VERSION,kJniAbiVersion, and thechdb.jni.abi.versionMaven property; native shims and Java must be rebuilt togetherMacroscope summarized d28b9f7.