Repository navigation
Conversation
Deploying nmrium with
|
| Latest commit: |
7b65cab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd59f652.nmrium.pages.dev |
| Branch Preview URL: | https://fix-range-signals-baseline-n.nmrium.pages.dev |
Member
|
This file still does not works seems to me. 
I also wonder what is this spectrum (median(|y|) * 8 |
Member
Author
|
This PR is not related with the dominant carbon solvent signal. this PR is tackle that we are taking the noise level calculated directly in the ROI instead of the global noise level that includes the baseline points in the calculation. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The peak picking cutoff used inside a range was derived from the range itself (3 * median of the ROI). In a narrow range most points belong to the peaks, so the cutoff was close to, or bigger than, the peak height: no peak was picked and the range was left without signals (empty Kind, assignment not editable).
The detection now uses the baseline noise of the whole spectrum (median(|y|) * 8, as autoPeakPicking does) and, when nothing can be detected while the range contains something above that baseline, the point of maximum intensity is reported as a signal of unknown multiplicity. A range that only contains noise stays empty.
Refs: #4435