Skip to content

perf: avoid forced GC during multipart restores - #1

Merged
chenrui333 merged 1 commit into
patch/9.7.0-backpressurefrom
rchen.INFRAOPS-20584.remove-forced-gc
Oct 13, 2026
Merged

chenrui333 merged 1 commit into
patch/9.7.0-backpressurefrom
rchen.INFRAOPS-20584.remove-forced-gc

Conversation

@chenrui333

Copy link
Copy Markdown
Owner

Summary

  • Remove synchronous forced GC between cache parts and after merges; rely on backpressure and normal V8 GC.
  • Remove obsolete exposed-GC startup guidance and runtime flag.
  • Cover concurrent multipart cold restores, completed merges, and warm byte equality.

Notes

  • Targets patch/9.7.0-backpressure; no dependency, schema, storage API, or deployment changes.
  • Node 25 type-check/build/lint passed. SQLite/filesystem: 16 tests passed, 1 skipped. SQLite/S3: 18 passed.
  • The local candidate image passed 16 SHA256-checked cold/warm restores. A controlled 8-entry/64-part comparison showed substantial forced-GC overhead; this is not a peak-load availability guarantee. Image verification used a compiler-equipped local Node 25 base.

References

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T18:24:41.142539Z 0253b40 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenrui333
chenrui333 merged commit 8bdbafc into patch/9.7.0-backpressure Oct 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant