Repository navigation
fix(management-api): honor repoId when deleting cache entries - #10
Closed
chenrui333 wants to merge 1 commit into
Closed
chenrui333 wants to merge 1 commit into
chenrui333 wants to merge 1 commit into
Conversation
`DELETE /management-api/cache-entries` accepted a `repoId` filter and documented it, but never applied it, so a delete filtered only by repository removed every cache entry of every repository. Apply it like the other filters. The Rust rewrite in falcondev-oss#288 already fixes this; this is the same fix for the current TypeScript server. Signed-off-by: Rui Chen <rui@chenrui.dev>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
Author
|
Superseded by upstream v9.10.0 (falcondev-oss#296). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DELETE /management-api/cache-entriesaccepts and documents arepoIdfilter, but the handler never applies it. A delete filtered only by repository therefore removes every cache entry of every repository.This PR applies
repoIdlike the other filters.Test
tests/management-api.test.tssaves the same key/version/scope for two repositories, deletes by onerepoIdthrough the API and checks that the other repository's entry survives. It fails ondev(both entries are deleted) and passes here.tests/setup.tssets aMANAGEMENT_API_KEYso the API is enabled in tests.pnpm test:run(sqlite + filesystem) passes;type-check, eslint and prettier are clean.Notes
falcondev-oss#288 already fixes this in Rust (
bulk_deletion_respects_every_filter). This is the same one-line fix for the current TypeScript server.