Repository navigation
Conversation
Dmod_TakeDeviceSecret(): the platform hands out a secret unique to the device (or the firmware build) - to be taken once, by the module that owns the policy (dmdevfs), which serves it under a node with permissions. The weak default returns -ENOSYS, as Dmod_Reboot. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing: a module that imports a SAL function the loader does not have crashes at load time on an older loader (found while testing dmdevfs against the released loader), so adding a SAL function for this makes every consumer's CI depend on a new runtime image. The secret will be handed over with an ioctl on the dmdevfs mount instead (a new DMDRVI_IOCTL_DEVFS_* command), which needs no change in the loader. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Dmod_TakeDeviceSecret(Buffer, Size), a platform-overridable SAL function (likeDmod_Reboot, #333): the platform that boots the system hands out a secret unique to the device (or to the firmware build), to be taken once.-ENOSYS(the host, tests). A platform overrides it: the length on success,-ENOSPCwhen the buffer is too small (the secret is then not consumed),-EACCESonce it was taken,-EINVALfor a NULL buffer.The weak default is tested (
tests_dmod_device_secret, passes). The first user is dmod-boot (it supplies the secret at build time) and dmdevfs.🤖 Generated with Claude Code