Repository navigation
Add configurable license installation directory to dmf-get - #336
Merged
Merged
Conversation
JohnAmadis
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dmf-getcurrently installs licenses only at destinations specified in package.dmrfiles. Add--license-dir <path>and theDMOD_LICENSE_DIRenvironment variable so callers can collect them separately, for example:License resources are installed under
<path>/<module>/<source-name>, including recursively installed dependencies. The CLI option overrides the environment variable; without either setting, existing destinations and mini-mode behavior are preserved. An explicit license directory includes licenses in mini mode without changing license acceptance. Directory resources copy their contents without nesting on repeated extraction, and failures writing requested licenses produce a failing installation result.Updates CLI help and documentation. Adds local-package integration coverage for default destinations, relative/absolute paths and spaces, multiple licenses, directory resources, dependencies and
.dmdinput, mini mode, environment precedence, rejection of license terms, and invalid or unwritable destinations. The existing integration suite invokes the new tests.Validation:
dmf-get: passed.tests/integration/test_dmf_get.shsuite, including the new license tests: passed.git diff --check: passed.