Repository navigation
knowledge: Convex keys and parallel writers, deploy target guard, Templater local settings, gate backticks - #333
Merged
choiyounggi merged 1 commit intoNov 5, 2026
Conversation
…rs, deploy target guard, Templater, gate backticks)
choiyounggi
approved these changes
Nov 5, 2026
choiyounggi
left a comment
Owner
There was a problem hiding this comment.
Thanks for the flush. Approving.
What I checked:
- Read all four new pages and the three merged edits. Every page has sources, and the convex-test correction (only helper-level tests miss the non-ASCII key) is stated clearly.
- Local run on the PR head
fbbdc19:wiki-structure-checks.jsreports 472 pages, 0 findings;wiki-lint-prohibitions.jsreports 86/86 compliant, 0 violations;check-versions.shok. - Full bats suite: 1786/1787 locally. The one failure (
wiki-mcp.batsRecall@5 real-model test) fails identically on main50a3af6, caused by a local uv offline cache miss, so it is unrelated to this PR. - CI
Testrun 41952461342: ubuntu and macOS both green (1..1787, only the expected canary failure). - No conflicts with main.
Notes:
Wiki agent gateskipped because the fork account is not on its allowlist, so this review stands in for it.- #300 may hit a one-line
related:conflict inenvironment-config.md; the later merge should keep both ids. - The backtick-stripping fix in
plan-gate.sh(owner note) is worth a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowledge flush — 7 insight(s)
7 queued rows claimed: 7 general insights, 4 new pages, 3 merged into existing pages, 0 dropped. One candidate claim was refuted during verification and corrected (see dad0a142c377a6f1).
This flush reuses the content of an earlier local commit (29a219b, same base
50a3af6) that never reached GitHub, because the contributor has read-only access to this repo. Every page was reviewed again and four were corrected. The PR comes from the forkjocenunes/dev-loopfor the same reason.Verified best-practice
9f5c3a177b7d59b1: a markdown code span copied into a gate
CHECK:line runs as command substitution.50a3af6.plan-gate.sh emit Akept the backticks inCHECK:, andgate-check.sh --runrecordedbaseline-tests-ranUNMET withexit=127; the bare bullet recorded MET withexit=0 matched: GATE_OK. A code span printingtouch <path>created the file, so the output really is executed.plan-gate.shlines 85 and 369 could strip the backticks. That is a skill change, so it is out of scope here.dad0a142c377a6f1: non-ASCII object keys fail in Convex at runtime.
dist/esm/values/value.js(validateObjectField).convexToJsonthrew for16–30,preçoand an emoji, and passed16-30. ThroughconvexTest, on convex 1.46.0 with convex-test 0.0.60 and on 1.47.0 with 0.0.62,t.queryandt.mutationthrew the same error, including for a nested key.convex-testpasses. That is false for a test that calls the registered function, so the page now says only helper-level tests miss it.064e6c85d3711615: parallel children patching one parent document exhaust write-conflict retries, and
convex-testcannot show it.dist/index.js(TransactionManager), @convex-dev/workpool README and 0.4.13dist/component/complete.js.maxParallelism: 1as a fix, so it is now a table row.onCompleteis inline only whenrunOnCompleteInlineis set, and the page now says so.fb8f286a0d295bd3: an
apiSpectimeout fromnpx convex runhides "Could not find function".dist/esm/cli/lib/run.jslines 52-56.convex run,apiSpecis queried only inside theCould not find functionbranch. The 1 s timeout is a field observation; no string for it exists in the npm package, so it comes from the server.ef1f9fc35666da7f: a target guard must resolve the environment in the CLI's own order.
dist/esm/cli/lib/deploymentSelection.jslines 84-85 andcommand.js,npx convex deploy --help.configcalls gave the file's value when unset and keptdev:exportedwhen exported.--helpconfirms the production default and the--dry-runwording.--prod,--deployment,--deployment-name,--preview-name,--url,--admin-key), which the candidate and the earlier draft omitted.9e1f0d72258b768a: prove "identical to main" by running the base commit's code against the committed snapshots.
--ci), https://vitest.dev/guide/snapshot.b68aa8912bbe777d: three Templater toggles live in device local storage, not
data.json.test/specs/migration.e2e.tsasserts these keys are not migrated.data.jsonvalues, and the vault scope ofApp.loadLocalStorage.All 13 cited URLs returned HTTP 200 on 2026-11-04.
Existing-layer check
Pages read: infrastructure-agent-orchestration-gate-evidence-exit-code-class, testing-quality-key-order-in-serialized-goldens, testing-quality-value-preserving-refactor-assertions, testing-quality-stale-artifact-baselines, debugging-signals-reading-error-messages, databases-transactions-optimistic-vs-pessimistic-locking
wiki_searchran on all 7 triggers. Top hits considered: 9f5c →qa-process-completion-claims,platforms-shells-heredoc-body-expansion-with-backtick-prose,infrastructure-agent-orchestration-gate-evidence-exit-code-class,platforms-shells-command-text-inspected-before-execution. 9e1f →testing-quality-key-order-in-serialized-goldens,testing-quality-behavior-not-implementation. The Convex, guard and Templater triggers returned only unrelated pages (best scores about 0.75).grep -i convexandgrep -i 'obsidian|templater'overwiki/returned nothing on main.gate-evidence-exit-code-class(new step, edge rows, sources); fb8f intoreading-error-messages(edge row, source); 9e1f intostale-artifact-baselines(edge row, sources).related:links added both ways:backend-node-boundaries-runtime-validation,databases-transactions-optimistic-vs-pessimistic-locking,infrastructure-config-environment-config,backend-node-runtime-env-files-with-process-loadenvfile.node scripts/wiki-structure-checks.js wikireports 472 pages, 0 findings;wiki-lint-prohibitions.jsreports 0 violations.Open-PR check
Listed 22 open
knowledge/*heads: #293, #298-#301, #304-#310, #315, #317-#319, #324, #328-#332. Diffed the 19 same-repo heads throughorigin/<head>, and the 3 fork heads (#298, #299, #300) throughpull/<n>/head, for Convex, Templater, Obsidian,git archive, workpool,.env, backtick, snapshot and command substitution. A title and body search for Convex or Templater returned nothing.environment-config.md, which this PR touches only inrelated:, so a trivial merge conflict is possible.Routing decision
New category
backend/node/convex: no existing node category (runtime, async, boundaries, language) fits a hosted backend's value rules and transaction model, and two pages share it.Local-layer candidates
none
🤖 Generated with Claude Code