Repository navigation
Fix package review findings before the 0.5.0 release - #36
Merged
Merged
Conversation
- Connect-CWC accepts server and credentials by position again - Keep CWC.* ErrorIds on Windows PowerShell 5.1 when a read fails - Build adds the Gallery's command tags; the package check verifies them - Write the about_ConnectWiseControlAPI help topic (it was empty) - CHANGELOG: document the Get-CWCSession default group change and move repository entries to a Development section Co-Authored-By: Claude <noreply@anthropic.com>
- ErrorId tests keep the error non-terminating, so they fail against Write-Error $_ on Windows PowerShell 5.1 (the first version did not) - about topic, CHANGELOG, README: say what Remove-* does without -Confirm:$false in each kind of host; MFA-only ErrorIds are marked; the HTTP 500 note no longer claims 0.4 retried - CHANGELOG: restore two entries dropped in the restructure Co-Authored-By: Claude <noreply@anthropic.com>
8 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes what a review of the built 0.5.0 package found before release. Merging this publishes nothing; no tag is pushed.
The review compared the
.nupkgfrom the release dry run with 0.4.0.0 from the Gallery, on PowerShell 7 and Windows PowerShell 5.1.Fixes that change the module
Connect-CWC 'server' $credworks again. Adding the sign-in parameter sets had removed the positions, so a 0.4-style positional call failed withPositionalParameterNotFound.-Serveris position 0 and-Credentialsposition 1 in every credential set. Secrets are never positional.Get-CWCLastContact,Invoke-CWCCommandandRemove-CWCSessionNotere-reported a caught error withWrite-Error $_, which on 5.1 replaces the ErrorId withWriteErrorException. They now use$PSCmdlet.WriteError($_), soCWC.NotConnectedand the otherCWC.*IDs survive on both editions.about_ConnectWiseControlAPIhas content. The topic shipped as an empty file. It now covers the three ways to sign in, the ErrorIds, the Remove-* confirmation and the upgrade notes.Get-CWCLastContactandUpdate-CWCSessionName("the control server").Fix that changes the package
PSIncludes_Functionand aPSFunction_*/PSCommand_*tag per command; the Gallery lists and finds commands by them. PowerShellGet v2 added them while packing, andPublish-PSResourcedoes not. A new build task (.build/gallery-tags.ps1) writes them into the built manifest (72 tags, 2107 of the 4000 characters allowed), andBuild/Test-ReleasePackage.ps1now fails if the package's.nuspeclacks any of them.Documentation
CHANGELOG.md[0.5.0]:Get-CWCSession -Type Support/Meetingwithout-GroupreadsAll Sessions/All Meetings, notAll Machines.-Confirm:$falsein each kind of unattended host. A blank line on redirected input accepts the prompt's default, which is Yes.README.md: the intro no longer says existing scripts keep working without qualification; the upgrade list has theGet-CWCSessionentry.Not changed
No positional-parameter entry in the breaking changes, because the break is fixed, not documented.
Testing
./Tests/test-local.ps1: all stages pass; 486 tests pass on both editions (9 new: positional connect, parameter positions, ErrorIds for the three functions,-ErrorAction Ignore, about topic, Gallery tags).-ErrorAction Stopand passed against the old code; a review caught that.WriteErrorExceptionbefore,CWC.NotConnectedafter../Build/Test-ReleasePackage.ps1passes with the tag check: 0.5.0, 32 functions, no aliases or import warnings on both editions../Build/Get-ReleaseInfo.ps1 -Tag v0.5.0passes.🤖 Generated with Claude Code