Skip to content

Harden the release and CI pipelines after review - #38

Merged
christaylorcodes merged 3 commits into
masterfrom
ci/release-hardening
Nov 12, 2026
Merged

christaylorcodes merged 3 commits into
masterfrom
ci/release-hardening

Conversation

@christaylorcodes

Copy link
Copy Markdown
Owner

Pull Request

Description

Hardens the release and CI pipelines after a review of the 0.5.0 release process. Merging this publishes
nothing; no tag is pushed.

Related Issue

None.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring / tests

Changes Made

Release workflow (.github/workflows/release.yml):

  • The publish job skips the upload when the version is already on the Gallery, so re-running after a late
    failure is safe.
  • The package hash the publish job compares comes from the build job's output.
  • The GitHub Release step is idempotent, and the wait for the Gallery listing moved after it.
  • AGENTS.md documents what to do when a release run fails.

Tools:

  • Every build, test and docs tool is pinned to an exact version in RequiredModules.psd1.
  • CI resolves them once and shares the folder between jobs.
  • Tests/test-local.ps1 imports each tool at its pinned version and prints it.

Checks:

  • The analyzer stage also fails on plain-text password and credential-type warnings.
  • A Pester run with no passing test fails.
  • The Build stage fails when no module was built. build.ps1 exits 0 after an aborted build, so a failed
    Gallery download (HTTP 502) used to report success. A failed first-time resolve of the build tools is retried.
  • CI runs on master are no longer cancelled by a newer push; release/** branches no longer run twice.

Testing

  • ./Tests/test-local.ps1 passes (analyzer, manifest, Pester on PS 7 and 5.1, docs drift)
  • Tested against a live ScreenConnect server (if applicable)

486 Pester tests pass on PowerShell 7.6 and Windows PowerShell 5.1 after the rebase onto master (f10cce0).
The changed release workflow has not run yet; a dry run (gh workflow run release.yml) follows the merge.

Checklist

  • Code follows project conventions (AGENTS.md)
  • Tests cover new/changed behavior
  • PSScriptAnalyzer reports zero errors
  • CHANGELOG.md updated (if applicable)
  • Documentation updated (if applicable)
  • New public function is in source/Public/ (not applicable)

🤖 Generated with Claude Code

christaylorcodes and others added 3 commits November 12, 2026 09:49
Release: the publish job skips the upload when the version is already on
the Gallery, so a re-run after a late failure is safe; the package hash
comes from the build job's output; the GitHub Release step is idempotent
and the wait for the Gallery listing moved after it. AGENTS.md documents
what to do when a release run fails.

Tools: every build, test and docs tool is pinned to an exact version in
RequiredModules.psd1. CI resolves them once and shares the folder between
jobs; test-local imports each tool at its pinned version and prints it.

Checks: the analyzer stage also fails on plain-text password and
credential-type warnings; a Pester run with no passing test fails; master
CI runs are no longer cancelled; release/** branches no longer run twice.

Co-Authored-By: Claude <noreply@anthropic.com>
build.ps1 exits 0 after an aborted build, so the stage reported success
when a Gallery download failed (HTTP 502) and no module was written. The
stage now requires a manifest written by the build, and repeats a failed
first-time resolve of the build tools from an empty folder.

Co-Authored-By: Claude <noreply@anthropic.com>
CI: runs outside pull requests get a concurrency group per commit, so a
waiting master run is never replaced; the tools artifact is kept as long
as the build artifact.

test-local: repeat the build only when a pinned tool is missing, remove a
half-filled tools folder after the last attempt too, and require the
manifest of the version being built.

Release: a version found on the Gallery fails a first attempt and is
accepted only on a re-run; a conflict on a re-run counts as uploaded; a
draft release for the tag is published. AGENTS.md tags the dry-run SHA.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@christaylorcodes
christaylorcodes merged commit 8f0a427 into master Nov 12, 2026
6 checks passed
@christaylorcodes
christaylorcodes deleted the ci/release-hardening branch November 12, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant